Commit 5641097

author

Jaroslaw Zolnowski

committed

refactor(hooks): suppress the codeql warning regarding replacing only the first occurrence of '>'

1 parent 3216297 commit 5641097Copy full SHA for 5641097

File tree

-1

lines changed

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,15 @@ function addPlatformBodyTag(indexPath, platform) {`
`37`	`37`	`newBodyTag = bodyTag.replace(classAttr, newClassAttr);`
`38`	`38`
`39`	`39`	`} else {`
	`40`	`+`
	`41`	`+ /*`
	`42`	+ The bodyTag contains only the first found of `>`, due to the return of the first element of the array from method
	`43`	`+ (findBodyTag)[https://github.com/xlts-dev/angularjs-ionic-v1/blob/c553c973d85142e66f119aed2fe3db83775f5f2b/hooks`
	`44`	`+ /after_prepare/010_add_platform_class.js#L57]. Therefore, we should replace only one tag`
	`45`	`+ */`
	`46`	`+ var closingBracketIdx = bodyTag.indexOf('>');`
`40`	`47`	`// add class attribute to the body tag`
`41`		`- newBodyTag = bodyTag.replace('>',' + platformClass + ' ' + cordovaClass + '">');`
	`48`	`+ newBodyTag = bodyTag.slice(0,closingBracketIdx)+' class="' + platformClass + ' ' + cordovaClass + bodyTag.slice(closingBracketIdx);`
`42`	`49`	`}`
`43`	`50`
`44`	`51`	`html = html.replace(bodyTag, newBodyTag);`

Comments

(0)