Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Adding default array example of correct rule #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalsnik merged 3 commits into vuejs:master from guillaumebriday:patch-1
Sep 28, 2018
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/rules/require-valid-default-prop.md
View file Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ props: {
// multiple possible types
propB: [String, Number],
// a number with default value
propC: {
Copy link
Member

@ota-meshi ota-meshi Sep 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is described in the comment of propE as follows,
// object/array defaults should be returned from a factory function
If you add an example near propE, I think that it is easy to understand.

guillaumebriday reacted with thumbs up emoji
Copy link
Contributor Author

@guillaumebriday guillaumebriday Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you're right, I'll make the change !

Also, I think we coud update the propE to use the arrow function ? What do you think about it ?

Copy link
Member

@ota-meshi ota-meshi Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumebriday Thank you for your suggestion.
I have looked at other documents.

Many seemed to prefer the shorthand method.
(for example here)
Could you write it in shorthand default () {}?

guillaumebriday reacted with thumbs up emoji
type: Array,
default: () => []
},
propD: {
type: Number,
default: 100
Expand Down

AltStyle によって変換されたページ (->オリジナル) /