-
-
Notifications
You must be signed in to change notification settings - Fork 696
Adding default array example of correct rule #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guillaumebriday Thank you for this PR!
I have one request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it is described in the comment of propE as follows,
// object/array defaults should be returned from a factory function
If you add an example near propE, I think that it is easy to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep you're right, I'll make the change !
Also, I think we coud update the propE to use the arrow function ? What do you think about it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guillaumebriday Thank you for your suggestion.
I have looked at other documents.
Many seemed to prefer the shorthand method.
(for example here)
Could you write it in shorthand default () {}?
Thank you @guillaumebriday 👍 I updated defaults using function shorthand, instead of arrow function. It is a bit more sensible way to write these defaults, methods and any other thing in Vue, as you won't get into trouble when this is wrong when you need to use it inside the function. This way you're prepared for it.
Hey @michalsnik sorry I could not check it out before.
Thanks for the update and the merge ! 👍
No description provided.