-
-
Notifications
You must be signed in to change notification settings - Fork 696
Fix: allow v-on without attribute values if it has verb modifiers (fixes #49)
#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your prompt fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 only one suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though @ is a simple alias I think it would be good idea to add more valid test examples with v-on, like e.g.:
<template><div v-on:click.prevent></div></template>
<template><div v-on:click.native.stop></div></template>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added those!
Released in v3.3.0
Fixes #49.
This PR fixes false positive of
no-invalid-v-onrule.If a
v-ondirective has verb modifiers (.stopor.prevent), now that rule allow the directive even if it does not have attribute values.