Commit b0d613c

mysticateamichalsnik

authored and

committed

Fix: allow v-on without attribute values if it has verb modifiers (fixes #49) (#50)

* Fix: allow `v-on` without attribute values if it has verb modifiers (fixes #49) * Chore: add more tests

1 parent a8bdf72 commit b0d613cCopy full SHA for b0d613c

File tree

+27

-5

lines changed

+27

-5

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -8,7 +8,7 @@ This rule reports `v-on` directives in the following cases:
`8`	`8`
`9`	`9`	- The directive does not have that event name. E.g. `<div v-on="foo"></div>`
`10`	`10`	- The directive has invalid modifiers. E.g. `<div v-on:click.bbb="foo"></div>`
`11`		-- The directive does not have that attribute value. E.g. `<div v-on:click></div>`
	`11`	+- The directive does not have that attribute value and any verb modifiers. E.g. `<div v-on:click></div>`
`12`	`12`
`13`	`13`	`This rule does not check syntax errors in directives because it's checked by [no-parsing-error] rule.`
`14`	`14`
`@@ -31,7 +31,9 @@ This rule does not check syntax errors in directives because it's checked by [no`
`31`	`31`	`<div>`
`32`	`32`	`<div v-on:click="foo"></div>`
`33`	`33`	`<div @click="foo"></div>`
`34`		`- <div @click.left.prevent="foo"></div>`
	`34`	`+ <div @click.left="foo"></div>`
	`35`	`+ <div @click.prevent></div>`
	`36`	`+ <div @click.stop></div>`
`35`	`37`	`</div>`
`36`	`38`	`</template>`
`37`	`39`	```

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,9 @@ const VALID_MODIFIERS = new Set([`
`20`	`20`	`'native', 'once', 'left', 'right', 'middle', 'passive', 'esc', 'tab',`
`21`	`21`	`'enter', 'space', 'up', 'left', 'right', 'down', 'delete'`
`22`	`22`	`])`
	`23`	`+const VERB_MODIFIERS = new Set([`
	`24`	`+ 'stop', 'prevent'`
	`25`	`+])`
`23`	`26`
`24`	`27`	`/**`
`25`	`28`	`* Creates AST event handlers for no-invalid-v-on.`
`@@ -47,11 +50,11 @@ function create (context) {`
`47`	`50`	`})`
`48`	`51`	`}`
`49`	`52`	`}`
`50`		`- if (!utils.hasAttributeValue(node)) {`
	`53`	`+ if (!utils.hasAttributeValue(node)&&!node.key.modifiers.some(VERB_MODIFIERS.has,VERB_MODIFIERS)) {`
`51`	`54`	`context.report({`
`52`	`55`	`node,`
`53`	`56`	`loc: node.loc,`
`54`		`- message: "'v-on' directives require that attribute value."`
	`57`	`+ message: "'v-on' directives require that attribute value or verb modifiers."`
`55`	`58`	`})`
`56`	`59`	`}`
`57`	`60`	`}`

Lines changed: 18 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,18 @@ tester.run('no-invalid-v-on', rule, {`
`42`	`42`	`{`
`43`	`43`	`filename: 'test.vue',`
`44`	`44`	`code: '<template><div @keydown.27="foo"></div></template>'`
	`45`	`+ },`
	`46`	`+ {`
	`47`	`+ filename: 'test.vue',`
	`48`	`+ code: '<template><el-from @submit.native.prevent></el-form></template>'`
	`49`	`+ },`
	`50`	`+ {`
	`51`	`+ filename: 'test.vue',`
	`52`	`+ code: '<template><div v-on:click.prevent></div></template>'`
	`53`	`+ },`
	`54`	`+ {`
	`55`	`+ filename: 'test.vue',`
	`56`	`+ code: '<template><div v-on:click.native.stop></div></template>'`
`45`	`57`	`}`
`46`	`58`	`],`
`47`	`59`	`invalid: [`
`@@ -58,7 +70,12 @@ tester.run('no-invalid-v-on', rule, {`
`58`	`70`	`{`
`59`	`71`	`filename: 'test.vue',`
`60`	`72`	`code: '<template><div v-on:click></div></template>',`
`61`		`- errors: ["'v-on' directives require that attribute value."]`
	`73`	`+ errors: ["'v-on' directives require that attribute value or verb modifiers."]`
	`74`	`+ },`
	`75`	`+ {`
	`76`	`+ filename: 'test.vue',`
	`77`	`+ code: '<template><div @click></div></template>',`
	`78`	`+ errors: ["'v-on' directives require that attribute value or verb modifiers."]`
`62`	`79`	`}`
`63`	`80`	`]`
`64`	`81`	`})`

Comments

(0)