Skip to content

test(integrations/import): align fixture to ESLint ^9 #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

2nofa11 wants to merge 1 commit into vuejs:master

from 2nofa11:test/align-import-integration-eslint9

+6 −3

Open

test(integrations/import): align fixture to ESLint ^9 #2931

Changes from all commits

Commits

Show all changes

Select commit

test(integrations/import): align fixture to ESLint ^9

2nofa11 Sep 6, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

5 changes: 4 additions & 1 deletion tests/integrations/eslint-plugin-import.js

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -35,6 +35,9 @@ describe('Integration with eslint-plugin-import', () => {
		return
		}

	cp.execSync(`${ESLINT} a.vue`, { cwd: PLUGIN_DIR, stdio: 'inherit' })
	cp.execSync(`${ESLINT} --no-config-lookup a.vue`, {
Copy link Contributor Author @2nofa11 2nofa11 Sep 6, 2025 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Previously, the integration fixture used ESLint v7 and relied solely on legacy `.eslintrc.*` resolution, so it didn’t look up the repo‐root flat config (`eslint.config.mjs`). As a result, the import of 'eslint/config' (introduced with ESLint v9) wasn’t invoked, and the error did not occur. As a mitigation, this PR adds --no-config-lookup to the fixture’s ESLint invocation so it won’t traverse to the repo root and load eslint.config.mjs. This isolates the fixture, avoids importing 'eslint/config', and prevents ERR_PACKAGE_PATH_NOT_EXPORTED in CI (including the ESLint v8 matrix job).
	cwd: PLUGIN_DIR,
	stdio: 'inherit'
	})
		})
		})

4 changes: 2 additions & 2 deletions tests/integrations/eslint-plugin-import/package.json

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -8,8 +8,8 @@
		"author": "Toru Nagashima (https://github.com/mysticatea)",
		"license": "MIT",
		"dependencies": {
	"eslint": "^7.0.0",
	"eslint-plugin-import": "~2.23.4",
	"eslint": "^9.0.0",
	"eslint-plugin-import": "^2.31.0",
		"eslint-plugin-vue": "file:../../.."
		}
		}