Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test(integrations/import): align fixture to ESLint ^9 #2931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2nofa11 wants to merge 1 commit into vuejs:master
base: master
Choose a base branch
Loading
from 2nofa11:test/align-import-integration-eslint9

Conversation

Copy link
Contributor

@2nofa11 2nofa11 commented Sep 6, 2025

Update tests/integrations/eslint-plugin-import/package.json to use ESLint ^9 (or ^8) and eslint-plugin-import ^2.31.0, matching the plugin’s peerDependencies (^8 || ^9).
Test-only; no user-facing changes.

closed #2930
Linked to: #2916

Copy link

changeset-bot bot commented Sep 6, 2025
edited
Loading

⚠️ No Changeset found

Latest commit: dd29176

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@2nofa11 2nofa11 force-pushed the test/align-import-integration-eslint9 branch from e090489 to dd29176 Compare September 6, 2025 08:32
@@ -35,6 +35,9 @@ describe('Integration with eslint-plugin-import', () => {
return
}

cp.execSync(`${ESLINT} a.vue`, { cwd: PLUGIN_DIR, stdio: 'inherit' })
cp.execSync(`${ESLINT} --no-config-lookup a.vue`, {
Copy link
Contributor Author

@2nofa11 2nofa11 Sep 6, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the integration fixture used ESLint v7 and relied solely on legacy .eslintrc.* resolution, so it didn’t look up the repo‐root flat config (eslint.config.mjs).
As a result, the import of 'eslint/config' (introduced with ESLint v9) wasn’t invoked, and the error did not occur.

As a mitigation, this PR adds --no-config-lookup to the fixture’s ESLint invocation so it won’t traverse to the repo root and load eslint.config.mjs.
This isolates the fixture, avoids importing 'eslint/config', and prevents ERR_PACKAGE_PATH_NOT_EXPORTED in CI (including the ESLint v8 matrix job).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align import integration fixture with supported ESLint versions
1 participant

AltStyle によって変換されたページ (->オリジナル) /