-
-
Notifications
You must be signed in to change notification settings - Fork 696
Test support for multiple versions of ESLint Stylistic #2884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: bdcd7f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
e45a2c2 to
7f48833
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
7f48833 to
32b030a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I haven't tested this version in any projects though, to check whether this "breaks"/changes anything there.
eslint-plugin-vue supports quite a lot versions of stylistic. I probably would have dropped one or two of them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks you!
check whether this "breaks"/changes anything there
Since this introduces only an optional dependency with nearly all versions allowed, I think it should be fine.
supports quite a lot versions of stylistic. I probably would have dropped one or two of them
Yeah, we should definitely do that in the future, but I didn't want to introduce a (potentially) breaking change in this small PR.
Uh oh!
There was an error while loading. Please reload this page.
Follow-up to #2830 (comment).
@ST-DDT It would be great if you could have a look at this 🙂