-
-
Notifications
You must be signed in to change notification settings - Fork 696
test(func-call-spacing): remove obsolete compatibility code #2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(func-call-spacing): remove obsolete compatibility code #2830
Conversation
⚠️ No Changeset found
Latest commit: 776cef3
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I missed that tests are failing
I removed the column property for now, so this is no longer blocked.
In the future, we should probably look into why this reports different locations depending on whether stylistic is present or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll look into the differences. For reference: #2884
Continuation of #2793
This PR converts all error assertions for
func-call-spacingto include both error message and full location checks.