-
-
Notifications
You must be signed in to change notification settings - Fork 697
test(no-deprecated-slot-attribute): make tests more strict #2793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(no-deprecated-slot-attribute): make tests more strict #2793
Conversation
⚠️ No Changeset found
Latest commit: 393149e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Better test coverage is always appreciated 🙂
Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Continuation of #2773 (comment)
This PR converts all error assertions for
no-deprecated-slot-attributeto include both error message and full location checks.Is this kind of PR appreciated? If not, we can close it. If yes, I will create one for each rule one at a time.