-
-
Notifications
You must be signed in to change notification settings - Fork 696
test(array-bracket-spacing): make tests more strict #2800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(array-bracket-spacing): make tests more strict #2800
Conversation
⚠️ No Changeset found
Latest commit: d8ccaa4
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Do you prefer these small PRs or would you prefer larger PRs?
How many test files should I update in one PR?
- 1:1
- 5:1
- One PR for each starting letter
- One PR for each starting word
- All in one PR
- Other?
I myself prefer small PRs as they have a lower chance of merge conflicts.
But I can understand, if this would cause issues on your side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! These small PRs are fine for me, but larger ones (like all rules starting with the same letter) would be fine, too.
Continuation of #2793
This PR converts all error assertions for
array-bracket-spacingto include both error message and full location checks.