-
Notifications
You must be signed in to change notification settings - Fork 24
Added typing stub file #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ImFstAsFckBoi
ImFstAsFckBoi
force-pushed
the
main
branch
2 times, most recently
from
August 5, 2024 15:06
1b92e66 to
1b514bd
Compare
I've now also added a test case for this... 4 months later 🙃. I also cleaned up git history.
@ImFstAsFckBoi
ImFstAsFckBoi
force-pushed
the
main
branch
2 times, most recently
from
August 6, 2024 06:42
f14249b to
4aa3c27
Compare
Adds mypy dependencny to github tests
@ImFstAsFckBoi
ImFstAsFckBoi
force-pushed
the
main
branch
from
August 26, 2024 13:30
4aa3c27 to
7fa1884
Compare
penberg
added a commit
that referenced
this pull request
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This adds a stub file, adding type hints in Python. This added the
connectfunction as well as theConnectionandCursorclasses. Everything is in thelibsql_experimental.pyifile. According to this PyO3 documentation, as long as there is no other Python files (excluding examples) Maturin will automatically install this file correctly, adding__init__.pyiandpy.typedto site-packages. Below is a before and after example for theconnectfunction.If there is anything I missed or misunderstood, let me know and ill fix it :)
before
image