Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit a334d9e

Browse files
committed
Revert "Added typing stub file (#48)"
This reverts commit eb91431, reversing changes made to 8e342c0.
1 parent b01a8a0 commit a334d9e

File tree

3 files changed

+1
-93
lines changed

3 files changed

+1
-93
lines changed

‎.github/workflows/pr-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,6 @@ jobs:
3636
run: |
3737
python3 -m venv .env # maturin requires a virtualenv
3838
source .env/bin/activate
39-
pip3 install maturin pytest mypy
39+
pip3 install maturin pytest
4040
maturin develop
4141
pytest

‎libsql_experimental.pyi

Lines changed: 0 additions & 65 deletions
This file was deleted.

‎tests/test_suite.py

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -298,33 +298,6 @@ def test_int64(provider):
298298
res = cur.execute("SELECT * FROM data")
299299
assert [(1, 1099511627776)] == res.fetchall()
300300

301-
def test_type_adherence(capsys):
302-
try:
303-
from mypy.stubtest import test_stubs, parse_options
304-
except (ImportError, ModuleNotFoundError):
305-
# skip test if mypy not installed
306-
pytest.skip("Cant test type stubs without mypy installed")
307-
308-
# run mypy stubtest tool. Equivalent to running the following the terminal
309-
"""
310-
stubtest --concise libsql_experimental | \
311-
grep -v 'which is incompatible with stub argument type'
312-
"""
313-
test_stubs(parse_options(["--concise", "libsql_experimental"]))
314-
cap = capsys.readouterr()
315-
316-
# this is part of error reported if is default parameter is ellipsis
317-
# `arg: type = ...` which is a nicer way to hide implementation from user
318-
# than having the more "correct" `arg: type | None = None` everywhere
319-
ellipsis_err = "which is incompatible with stub argument type"
320-
321-
lines = cap.out.split("\n")
322-
lines = filter(lambda x: ellipsis_err not in x, lines) # filter false positives from ellipsis
323-
lines = filter(lambda x: len(x) != 0, lines) # filter empty lines
324-
325-
# there will always be one error which i dont know how to get rid of
326-
# `libsql_experimental.libsql_experimental failed to find stubs`
327-
assert len(list(lines)) == 1
328301

329302
def connect(provider, database, isolation_level="DEFERRED", autocommit=-1):
330303
if provider == "libsql-remote":

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /