-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Ignore failing downstream dependencies#4196
Merged
Merged
Conversation
@bajtos
bajtos
requested review from
clark0x,
ebarault,
fabien and
zbarbuto
as code owners
May 14, 2019 07:44
dhmlau
dhmlau
approved these changes
May 14, 2019
The following dependencies are always failing the CI builds, let's ignore them when testing changes in `loopback` package: - bluemix-service-broker - gateway-director-bluemix - plan-manager Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
@bajtos
bajtos
force-pushed
the
ignore-failing-downstream-builds
branch
from
May 14, 2019 14:17
ac55b87 to
716347e
Compare
Member
Author
@dhmlau @rmg It looks like cis-jenkins is not picking up the changes from this pull request. Do you know if the changes need to land on master first, before cis-jenkins updates the ignore list?
I am adding these lines to package.json:
{
"ci": {
"downstreamIgnoreList": [
"bluemix-service-broker",
"gateway-director-bluemix",
"plan-manager"
]
}
}CI failures:
Screen Shot 2019年05月14日 at 17 21 06
loopback/node=6.x,os=windows — Failed! (716347e)
This failure is not related to my changes.
Building remotely on windows-64-0.10
(build-windows windows-0.10 x64 windows-64 0.10 windows)
in workspace C:\jenkins\workspace\loopback\d60c4a15
Wiping out workspace first.
java.nio.file.FileSystemException:
C:\jenkins\workspace\loopback\d60c4a15\xunit.xml:
The process cannot access the file because it is being used by another process.
dhmlau
commented
May 14, 2019
Member
bajtos
commented
May 14, 2019
Member
Author
ok, let's get this landed 🤞 we can always tweak the config in package.json if needed 🔧 🔨
rmg
commented
May 14, 2019
Member
Correct, this would need to land for the repo scanner to see it on its next scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following dependencies are always failing the CI builds, let's
ignore them when testing changes in
loopbackpackage: