-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Drop Node.js 6.x + update Karma and nyc dependencies to their latest versions#4194
Drop Node.js 6.x + update Karma and nyc dependencies to their latest versions #4194bajtos merged 3 commits into
Conversation
@jannyHou
jannyHou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The jenkins test still run on node 6 and fails, not sure why it still runs after specifying
"engines": {
"node": ">=8"
},
Could you double check? Other than the node 6 failure the PR LGTM 👍
dhmlau
commented
May 13, 2019
Regarding the CI failure, do we have downstream failures for loopback-connector-openapi and loopback-connector-swagger before?
Status for Travis is pending, but when I clicked on Details, they are all passed.
Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
6323e81 to
686c6fe
Compare
bajtos
commented
May 14, 2019
The jenkins test still run on node 6 and fails. Could you double check?
I am not sure why that happened. I re-run the build and node 6 seems to be fine now:
[cis-jenkins] x64 && linux && nvm,8 — Success! (686c6fe)
bajtos
commented
May 14, 2019
Regarding the CI failure, do we have downstream failures for
loopback-connector-openapiandloopback-connector-swaggerbefore?
I re-run the build and both connectors passed now. I suspect these connectors are calling external services and there was an intermittent networking problem that caused the tests to fail.
bajtos
commented
May 14, 2019
[cis-jenkins] downstream: loopback-sandbox@master — Failed! (686c6fe)
Opened a PR to fix the problem: strongloop/loopback-sandbox#26
[cis-jenkins] downstream: loopback-example-bluemix@master — Failed! (686c6fe)
Opened a PR to fix the problem: strongloop/loopback-example-bluemix#16
[cis-jenkins] downstream: lb-con-test-app@master — Failed! (686c6fe)
Opened a PR to fix the problem, the repo is hosted internally inside IBM.
[cis-jenkins] downstream: bluemix-service-broker@develop — Failed! (686c6fe)
[cis-jenkins] downstream: gateway-director-bluemix@develop — Failed! (686c6fe)
[cis-jenkins] downstream: plan-manager@develop — Failed! (686c6fe)
The builds are failing for unrelated errors and IIRC, they have been failing for long time. Let's ignore these downstream dependencies - see #4196
Description
I noticed that
npm installis reporting security vulnerabilities in our dev dependencies. This pull request updates the relevant packages to their latest version.Note that we have more outdated dependencies, but updating them is not trivial, therefore I am leaving such updates out of scope of this pull request.
Some of our dependencies are no longer supporting Node.js 6.x, thus I also need to drop Node.js 6.x from the platforms we are testing on our CI.