-
-
Notifications
You must be signed in to change notification settings - Fork 877
feat: implement toLocaleString method in dstructs/named-typed-tuple
#8009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kgryte
merged 35 commits into
stdlib-js:develop
from
Gauravkaushik-1206:fix-tolocale-string
Sep 8, 2025
Merged
feat: implement toLocaleString method in dstructs/named-typed-tuple
#8009
kgryte
merged 35 commits into
stdlib-js:develop
from
Gauravkaushik-1206:fix-tolocale-string
Sep 8, 2025
+201
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Getting Started
- Please read our contributing guidelines if you haven't already.
- For development guidance, refer to the development guide.
Next Steps
- A project maintainer will approve GitHub Actions workflows for your PR.
- All CI checks must pass before your submission can be fully reviewed.
- You'll need to address any failures in linting or unit tests.
Running Tests Locally
You can use make to run any of the CI commands locally from the root directory of the stdlib repository:
# Run tests for all packages in the math namespace: make test TESTS_FILTER=".*/@stdlib/math/.*" # Run benchmarks for a specific package: make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"
If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.
If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.
We appreciate your contribution!
Documentation Links
Hello! Thank you for your contribution to stdlib.
We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
-
Please read our contributing guidelines.
-
Update your pull request description to include this checked box:
- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)
This acknowledgment confirms that you've read the guidelines, which include:
- The developer's certificate of origin
- Your agreement to license your contributions under the project's terms
We can't review or accept contributions without this acknowledgment.
Thank you for your understanding and cooperation. We look forward to reviewing your contribution!
@stdlib-bot
stdlib-bot
added
First-time Contributor
A pull request from a contributor who has never previously committed to the project repository.
Needs Review
A pull request which needs code review.
labels
Sep 3, 2025
Coverage Report
The above coverage report was generated for the changes in this PR. |
@stdlib-bot
stdlib-bot
added
the
Good First PR
A pull request resolving a Good First Issue.
label
Sep 3, 2025
kgryte
kgryte
reviewed
Sep 3, 2025
...e/examples/index.js
@Gauravkaushik-1206 You can include tests in this PR. Same thing for adding docs, benchmarks, etc.
@kgryte
kgryte
added
Needs Changes
Pull request which needs changes before being merged.
and removed
Needs Review
A pull request which needs code review.
labels
Sep 3, 2025
1 task
...x-of` PR-URL: stdlib-js#8007 Closes: stdlib-js/metr-issue-tracker#71 Ref: stdlib-js#2656 Reviewed-by: Athan Reines <kgryte@gmail.com>
...x-of` PR-URL: stdlib-js#8008 Closes: stdlib-js/metr-issue-tracker#72 Ref: stdlib-js#2656 Reviewed-by: Athan Reines <kgryte@gmail.com>
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
docs, benchmarks already include the toLocaleString() and i have included the tests.
1 task
@kgryte
kgryte
added
Needs Review
A pull request which needs code review.
and removed
Needs Changes
Pull request which needs changes before being merged.
labels
Sep 5, 2025
--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---
@stdlib-bot
stdlib-bot
added
Potential Duplicate
There might be another pull request resolving the same issue.
and removed
First-time Contributor
A pull request from a contributor who has never previously committed to the project repository.
labels
Sep 6, 2025
any update ??
...st-index-of/README.md
...st-index-of/benchmark/benchmark.js
...st-index-of/docs/types/index.d.ts
...st-index-of/examples/index.js
@kgryte
kgryte
removed
the
Needs Changes
Pull request which needs changes before being merged.
label
Sep 7, 2025
@stdlib-bot
stdlib-bot
added
the
bot: In Progress
Pull request is currently awaiting automation.
label
Sep 7, 2025
kgryte
kgryte
reviewed
Sep 7, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
/stdlib merge
@kgryte, the slash command failed to complete. Please check the workflow logs for details.
@stdlib-bot
stdlib-bot
removed
the
bot: In Progress
Pull request is currently awaiting automation.
label
Sep 7, 2025
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
reviewed
Sep 8, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
reviewed
Sep 8, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
reviewed
Sep 8, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
reviewed
Sep 8, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
reviewed
Sep 8, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
reviewed
Sep 8, 2025
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte
approved these changes
Sep 8, 2025
/stdlib merge
@stdlib-bot
stdlib-bot
added
the
bot: In Progress
Pull request is currently awaiting automation.
label
Sep 8, 2025
@stdlib-bot
stdlib-bot
removed
the
bot: In Progress
Pull request is currently awaiting automation.
label
Sep 8, 2025
@kgryte
kgryte
changed the title
(削除) feat(named-typed-tuple): implement toLocaleString function (削除ここまで)
(追記) feat: implement Sep 8, 2025
toLocaleString method in dstructs/named-typed-tuple (追記ここまで)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
Resolves #6976
Description
This pull request implements the
toLocaleString()function inlib/node_modules/@stdlib/dstructs/named-typed-tuple/lib/main.js,which was flagged by ESLint under the
no-warning-commentsrule.Related Issues
Questions
I have written test cases for this function. Would you like me to include them in this PR or submit them separately?
Other Information
No additional information.
Checklist
@stdlib-js/reviewers