-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Remove unnecessary reflection in RemoteChunkHandlerFactoryBean
#4839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
@scordio
scordio
force-pushed
the
remove-reflection
branch
from
June 3, 2025 22:33
ece48ff to
ea35d45
Compare
@fmbenhassine
fmbenhassine
added
pr-for: enhancement
in: integration
for: backport-to-5.2.x
Issues that will be back-ported to the 5.2.x line
labels
Jun 3, 2025
This is great! Thank you for your contribution 👍
@fmbenhassine
fmbenhassine
merged commit Jun 3, 2025
3f0857b
into
spring-projects:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Since #173,
TaskletStepexposesgetTasklet(), making reflection inRemoteChunkHandlerFactoryBeanunnecessary.In addition, the
instanceofcheck can be simplified to anullcheck as thestepfield is already of typeTaskletStep.