Commit ea35d45

committed

Remove unnecessary reflection in RemoteChunkHandlerFactoryBean

Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>

1 parent 0164216 commit ea35d45Copy full SHA for ea35d45

File tree

-11

lines changed

spring-batch-integration/src/main/java/org/springframework/batch/integration/chunk
- RemoteChunkHandlerFactoryBean.java

-11

lines changed

Lines changed: 2 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -122,12 +122,12 @@ public ChunkHandler<T> getObject() throws Exception {`
`122`	`122`	`stepContributionSource = (StepContributionSource) chunkWriter;`
`123`	`123`	`}`
`124`	`124`
`125`		`- Assert.state(step instanceofTaskletStep, "Step [" + step.getName() + "] must be a TaskletStep");`
	`125`	`+ Assert.state(step != null, "A TaskletStep must be provided");`
`126`	`126`	`if (logger.isDebugEnabled()) {`
`127`	`127`	`logger.debug("Converting TaskletStep with name=" + step.getName());`
`128`	`128`	`}`
`129`	`129`
`130`		`- Tasklet tasklet = getTasklet(step);`
	`130`	`+ Tasklet tasklet = step.getTasklet();`
`131`	`131`	`Assert.state(tasklet instanceof ChunkOrientedTasklet<?>,`
`132`	`132`	`"Tasklet must be ChunkOrientedTasklet in step=" + step.getName());`
`133`	`133`
`@@ -227,15 +227,6 @@ private ChunkProcessor<T> getChunkProcessor(ChunkOrientedTasklet<?> tasklet) {`
`227`	`227`	`return (ChunkProcessor<T>) getField(tasklet, "chunkProcessor");`
`228`	`228`	`}`
`229`	`229`
`230`		`- /**`
`231`		`- * Pull a Tasklet out of a step.`
`232`		`- * @param step a TaskletStep`
`233`		`- * @return the Tasklet`
`234`		`- */`
`235`		`- private Tasklet getTasklet(TaskletStep step) {`
`236`		`- return (Tasklet) getField(step, "tasklet");`
`237`		`- }`
`238`		`-`
`239`	`230`	`private static Object getField(Object target, String name) {`
`240`	`231`	`Assert.notNull(target, "Target object must not be null");`
`241`	`232`	`Field field = ReflectionUtils.findField(target.getClass(), name);`

Comments

(0)