-
Notifications
You must be signed in to change notification settings - Fork 56
Refactor existing implementation for swift-driver change - #208
Merged
Merged
Conversation
polac24
marked this pull request as ready for review
May 30, 2023 04:46
polac24
requested review from
PatrikBillgren,
acbdev,
aleksandergrzyb and
vadim-smal
May 30, 2023 04:46
vadim-smal
vadim-smal
approved these changes
May 30, 2023
@vadim-smal
vadim-smal
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested but the changes look good.
polac24
commented
May 30, 2023
Collaborator
Author
We have several E2E tests so hopefully that covers all cases.
This was referenced May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it is highly possible that Xcode 15 beta (expected on in a week, on Jun 5th) will no longer support
SWIFT_USE_INTEGRATED_DRIVER: NO, we should be ready to add support for the integrated driver.This is a first PR that refactors the existing implementation so it the swift-driver PR will be easier to reason about.
This PR doesn't change anything in the business logic.
Includes:
BuildSettingsIntegrateAppenderto specify if theSWIFT_USE_INTEGRATED_DRIVERshould be added or not (for now, always add)swiftc, this is always done in a single process (at least from XCRemoteCache's perspective), in the driver world, that will be 2 independent processes*.swift) and output (*.d, *.o etc) files: either via a file (used currently) or explicitly in the cmd argument listXCSwiftc's logic is broken down to theXCSwiftAbstract, which will be shared with theXCSwiftFrontendnilin the swift-frontendNext steps
Add swift-frontend support (draft PR)