Skip to content

Navigation Menu

Sign in
Sign up

Swift-driver integration, Part II: add Swift front-end parsing stage - #209

Merged
polac24 merged 4 commits into
spotify:master from
polac24:add-driver-parsing
Jun 1, 2023
Merged

Swift-driver integration, Part II: add Swift front-end parsing stage #209
polac24 merged 4 commits into
spotify:master from
polac24:add-driver-parsing

Conversation

@polac24

@polac24 polac24 commented May 31, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Part II (out of IV) of the swift driver integration:

  • Introduces xcswift-frontend wrapper that parses input parameters and stores them into the structured module (struct)
  • Adds (very experimental for now) enable_swift_driver_integration config that will enable the driver integration
  • Plugs in XCSwiftFrontend and SwiftFrontendOrchestrator that are no-op for now, but in a follow-up PR will add swift-frontend processes synchronization

Previous PR: #208

file: primaryInputFilesURLs[i],
dependencies: dependenciesPaths.get(i).map(URL.init(fileURLWithPath:)),
object: outputPaths.get(i).map(URL.init(fileURLWithPath:)),
// for now - swift-dependencies are not requested in the driver compilation mode

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least I have never seen that

}

override public func run() throws {
// TODO: implement in a follow-up PR

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added separately to keep this PR small(er)


func run(criticalSection: () throws -> Void) throws {
// TODO: implement synchronization in a separate PR
try criticalSection()

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be added separately to keep this PR small(er)

@polac24 polac24 changed the title (削除) Add Swift front-end parsing stage (削除ここまで) (追記) Swift-driver integration, Part II: add Swift front-end parsing stage (追記ここまで) May 31, 2023
polac24 marked this pull request as ready for review May 31, 2023 04:56

@aleksandergrzyb aleksandergrzyb left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos. Looks great!

polac24 reacted with thumbs up emoji
let customRewriteEnvs: [String]?
let irrelevantDependenciesPaths: [String]?
let gracefullyHandleMissingCommonSha: Bool?
let enableSwifDriverIntegration: Bool?

@aleksandergrzyb aleksandergrzyb May 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let enableSwifDriverIntegration: Bool?
let enableSwiftDriverIntegration: Bool?

@aleksandergrzyb aleksandergrzyb May 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in others. 👀

// -target is required
case emitMissingTarget
// -moduleName is required
case emiMissingModuleName

@aleksandergrzyb aleksandergrzyb May 31, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
case emiMissingModuleName
case emitMissingModuleName

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatrikBillgren PatrikBillgren Awaiting requested review from PatrikBillgren
@vadim-smal vadim-smal Awaiting requested review from vadim-smal
@acbdev acbdev Awaiting requested review from acbdev
1 more reviewer
@aleksandergrzyb aleksandergrzyb aleksandergrzyb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /