-
Notifications
You must be signed in to change notification settings - Fork 573
Properly finalize ThreadPoolExecutors in file transfer agent - #2879
Open
jochenott wants to merge 2 commits into
Open
Properly finalize ThreadPoolExecutors in file transfer agent #2879jochenott wants to merge 2 commits into
jochenott wants to merge 2 commits into
Conversation
sfc-gh-turbaszek
sfc-gh-turbaszek
approved these changes
Aug 6, 2026
sfc-gh-turbaszek
added a commit
that referenced
this pull request
Aug 6, 2026
...agent Duplicate of #2879 by @jochenott. Shut down ThreadPoolExecutors via ExitStack instead of relying on GC finalizers. Fixes #2878.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3556240: FileTransferManager leaks threads #2878
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Fix a thread leak in the file transfer agent that was caused by not properly finalizing the thread pool executors.