-
Notifications
You must be signed in to change notification settings - Fork 573
SNOW-3556240: Properly finalize ThreadPoolExecutors in file transfer agent - #2994
Merged
sfc-gh-turbaszek merged 2 commits intoAug 6, 2026
Merged
Conversation
...agent Duplicate of #2879 by @jochenott. Shut down ThreadPoolExecutors via ExitStack instead of relying on GC finalizers. Fixes #2878.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snowflake Security Review
Security grade: A — Passed ✅
This PR was classified as LOW risk by the automated pre-screen.
codecov-commenter
commented
Aug 6, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## main #2994 +/- ## ========================================== + Coverage 65.08% 65.09% +0.01% ========================================== Files 123 123 Lines 17433 17436 +3 Branches 2392 2392 ========================================== + Hits 11346 11350 +4 Misses 5646 5646 + Partials 441 440 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sfc-gh-turbaszek
enabled auto-merge (squash)
August 6, 2026 13:07
sfc-gh-pczajka
sfc-gh-pczajka
approved these changes
Aug 6, 2026
sfc-gh-turbaszek
deleted the
turbaszek-SNOW-3556240-finalize-thread-pools
branch
August 6, 2026 13:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ThreadPoolExecutors inSnowflakeFileTransferAgent.transfer()viaExitStackinstead of relying on GC finalizers.transfer()and does not share these pools; no aio changes required.Test plan
PARAMETERS_SECRET)ThreadPoolExecutor-*threads after PUT without forcinggc.collect()Made with Cursor