-
-
Notifications
You must be signed in to change notification settings - Fork 177
build(nix): move to unstable channel #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As NixOS 23.11 will be out soon and the `shell.nix` is broken due to MSRV requirements (23.05 has 1.69.0, not 1.70.0), we can already move to unstable which is "beta 23.11" at this point.
https://github.com/rust-osdev/uefi-rs/blob/main/shell.nix#L20
Hm, our nix shell comes with rustup. We don't use rustc from nixpkgs. What do you mean by it's not working then? rustup installs the proper toolchain.
I see. Personally, even on Nix, I'm a big rustup fan and don't like the "pure Nix"-way when it comes to Rust in a shell. But I see that some folks don't want to use rustup.
Instead of switching to nixpkgs-unstable, I think, a better solution would be to either
a) use rust-overlay and add the latest stable rust toolchain into the PATH
b) switch to a flake-based shell and provide one rustup shell and one with a pinned rustc.
What do you say?
I see. Personally, even on Nix, I'm a big rustup fan and don't like the "pure Nix"-way when it comes to Rust in a shell. But I see that some folks don't want to use rustup.
Instead of switching to nixpkgs-unstable, I think, a better solution would be to either a) use rust-overlay and add the latest stable rust toolchain into the PATH b) switch to a flake-based shell and provide one rustup shell and one with a pinned rustc.
I think a) or c) is fine where c) could be just the same setup with 2 shells attribute sets instead of a Flake as I don't think it's necessary at all.
Uh oh!
There was an error while loading. Please reload this page.
As NixOS 23.11 will be out soon and the
shell.nixis broken due to MSRV requirements (23.05 has 1.69.0, not 1.70.0), we can already move to unstable which is "beta 23.11" at this point.Checklist