-
-
Notifications
You must be signed in to change notification settings - Fork 178
nix: update rust-toolchain in shell #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please leave some comments @RaitoBezarius - what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine: any concerns @nicholasbishop ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, but just for my own edification, why is this part of the change necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that rust-bin.fromRustupToolchainFile ../rust-toolchain.toml can pick the right toolchain for Nix.
82fcc92 to
e94629d
Compare
Now, a nix-shell always has the latest rust stable version, compliant to our rust-toolchain.toml file.
e94629d to
c26fb9e
Compare
This changes the rust-toolchain from
rustuptorust-bin.fromRustupToolchainFilecoming from https://github.com/oxalica/rust-overlay. This supersedes #994.TL;DR:
nix-shell --pure --run "rustc --version"is now1.73.Checklist