Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

style: apply/fix more clippy lints (from cargo::nursery) #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
phip1611 wants to merge 3 commits into main
base: main
Choose a base branch
Loading
from clippy-tightening

Conversation

Copy link
Member

@phip1611 phip1611 commented Sep 12, 2025 •
edited
Loading

Using clippy::nursery, I was able to perform the following improvements:

Steps to Undraft

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 self-assigned this Sep 12, 2025
@phip1611 phip1611 force-pushed the clippy-tightening branch 2 times, most recently from 9b911ae to cff70a4 Compare September 12, 2025 08:33
@@ -14,6 +14,8 @@
#![cfg_attr(docsrs, feature(doc_auto_cfg))]
#![deny(
clippy::all,
clippy::cargo,
clippy::nursery,
Copy link
Member

@nicholasbishop nicholasbishop Sep 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://doc.rust-lang.org/clippy/, nursery lints are "new lints that are still under development". I don't think we should enable these, since there will likely be false positives. If a lint's development is completed then it will naturally graduate to a different group.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fine :)

Background: I use it in all my personal projects and never experienced any drawbacks; but we also do not really need it. So yeah, I'll remove that part from the PR.

Nevertheless, it is beneficial to temporarily activate the corresponding lints locally and see what code can be improved - I found quite some nice improvements

@phip1611 phip1611 force-pushed the clippy-tightening branch 2 times, most recently from bdfb4d5 to 5a48c1c Compare September 13, 2025 08:37
@phip1611 phip1611 marked this pull request as ready for review September 13, 2025 08:42
@phip1611 phip1611 changed the title (削除) style: tighten clippy lints (削除ここまで) (追記) style: apply/fix more clippy lints (from cargo::nursery) (追記ここまで) Sep 13, 2025
@@ -745,7 +745,7 @@ impl PoolString {
pub unsafe fn new(text: *const Char16) -> crate::Result<Self> {
NonNull::new(text.cast_mut())
.map(|p| Self(PoolAllocation::new(p.cast())))
.ok_or(Status::OUT_OF_RESOURCES.into())
.ok_or_else(|| Status::OUT_OF_RESOURCES.into())
Copy link
Member

@nicholasbishop nicholasbishop Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split the ok_or_else changes to a separate PR? I'd like to review the other changes in isolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop left review comments

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /