Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Rollup of 6 pull requests #145970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 19 commits into rust-lang:master from GuillaumeGomez:rollup-pr11qds
Aug 28, 2025
Merged

Rollup of 6 pull requests #145970

bors merged 19 commits into rust-lang:master from GuillaumeGomez:rollup-pr11qds
Aug 28, 2025

Conversation

Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 28, 2025 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

maurer and others added 19 commits August 26, 2025 16:32 
Fix rust-lang#142284 by ensuring that `#![no_builtins]` crates can still emit bitcode
when proper (i.e., non-rustc) LTO (i.e., -Clinker-plugin-lto) is used.
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
...llvm
Don't export them from cdylibs. There is no need to do so and it
complicates exported_non_generic_symbols. In addition the GCC backend
likely uses different symbols and may potentially not even need us to
explicitly tell it to export the symbols it needs.
All other sanitizer symbols are handled in prepare_lto already.
...bute, r=fmease
Add new `doc(attribute = "...")` attribute
Fixes rust-lang#141123.
The implementation and purpose of this new `#[doc(attribute = "...")]` attribute is very close to `#[doc(keyword = "...")]`. Which means that luckily for us, most of the code needed was already in place and `@Noratrieb` nicely wrote a first draft that helped me implement this new attribute very fast.
Now with all this said, there is one thing I didn't do yet: adding a `rustdoc-js-std` test. I added GUI tests with search results for attributes so should be fine but I still plan on adding one for it once documentation for builtin attributes will be written into the core/std libs.
You can test it [here](https://rustdoc.crud.net/imperio/doc-attribute-attribute/foo/index.html).
cc `@Noratrieb` `@Veykril`
CFI: Make `lto` and `linker-plugin-lto` work the same for `compiler_builtins`
Fix rust-lang#142284 by ensuring that `#![no_builtins]` crates can still emit bitcode when proper (i.e., non-rustc) LTO (i.e., -Clinker-plugin-lto) is used.
...=jdonszelmann
Improve error messages around invalid literals in attribute arguments
r? `@jdonszelmann`
This previously created two errors, which is a bit ugly and the second one didn't add any value
Blocked on rust-lang#143193 
bootstrap: Explicitly mark the end of a failed test's captured output
While working on some compiletest stuff, I noticed that when bootstrap prints a failed test's captured output, there's no indication of where that output actually ends.
In addition to indicating where the captured output ends, this end marker also makes it easier to see the relevant test name when scrolling upwards in terminal output.
...=fmease
add doc-hidden to exports in attribute prelude
Seems to fix rust-lang#145870, at least temporarily. The underlying problem of course is still there.
r? `@fmease`
<img width="653" height="167" alt="image" src="https://github.com/user-attachments/assets/b5a8094c-849e-4328-997d-b772f9aa4088" />
Fixes rust-lang#145870 
...ovements, r=lqd
Move exporting of profiler and sanitizer symbols to the LLVM backend
Only the LLVM backend needs those specific symbols exported and it only needs them to be exported for LTO, not from cdylibs in general.
@rustbot rustbot added A-attributes Area: Attributes (`#[...]`, `#![...]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. rollup A PR which is a rollup labels Aug 28, 2025
Copy link
Member Author

@bors r+ p=5 rollup=never

Copy link
Collaborator

bors commented Aug 28, 2025

📌 Commit a60b96a has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2025
Copy link
Collaborator

bors commented Aug 28, 2025

⌛ Testing commit a60b96a with merge f2824da...

Copy link
Collaborator

bors commented Aug 28, 2025

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing f2824da to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2025
@bors bors merged commit f2824da into rust-lang:master Aug 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 28, 2025
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#142472 Add new doc(attribute = "...") attribute 89bbba48ba5197ed06cd2083856758f938a52a24 (link)
#145368 CFI: Make lto and linker-plugin-lto work the same for `... 249f56a7720e02cd910fec9df8b013982329da5f (link)
#145853 Improve error messages around invalid literals in attribute... 93e6994b88ed3c6549dae6223d2960da62d45e19 (link)
#145920 bootstrap: Explicitly mark the end of a failed test's captu... 6894dabccb5e7883f72bf5e645c525264e710b3d (link)
#145937 add doc-hidden to exports in attribute prelude f1008370e0f060e78de4ccae7438bb22fe51e615 (link)
#145965 Move exporting of profiler and sanitizer symbols to the LLV... 6a62c0a9fca955a94c1b02bccf199fc8fac10ba1 (link)

previous master: 35d55b34bf

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 35d55b3 (parent) -> f2824da (this PR)

Test differences

Show 330 test diffs

Stage 1

  • errors::verify_passes_abi_invalid_attribute_92: pass -> [missing] (J0)
  • errors::verify_passes_abi_invalid_attribute_93: [missing] -> pass (J0)
  • errors::verify_passes_abi_ne_91: pass -> [missing] (J0)
  • errors::verify_passes_abi_of_91: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_enum_105: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_106: [missing] -> pass (J0)
  • errors::verify_passes_attr_application_struct_enum_union_108: [missing] -> pass (J0)
  • errors::verify_passes_attr_only_in_functions_96: pass -> [missing] (J0)
  • errors::verify_passes_attr_only_in_functions_97: [missing] -> pass (J0)
  • errors::verify_passes_both_ffi_const_and_pure_45: [missing] -> pass (J0)
  • errors::verify_passes_cannot_stabilize_deprecated_112: [missing] -> pass (J0)
  • errors::verify_passes_const_stable_not_stable_121: pass -> [missing] (J0)
  • errors::verify_passes_custom_mir_phase_requires_dialect_142: pass -> [missing] (J0)
  • errors::verify_passes_custom_mir_phase_requires_dialect_143: [missing] -> pass (J0)
  • errors::verify_passes_debug_visualizer_unreadable_59: pass -> [missing] (J0)
  • errors::verify_passes_debug_visualizer_unreadable_60: [missing] -> pass (J0)
  • errors::verify_passes_doc_attr_not_crate_level_33: [missing] -> pass (J0)
  • errors::verify_passes_doc_cfg_hide_takes_list_36: pass -> [missing] (J0)
  • errors::verify_passes_doc_cfg_hide_takes_list_37: [missing] -> pass (J0)
  • errors::verify_passes_doc_fake_variadic_not_valid_26: [missing] -> pass (J0)
  • errors::verify_passes_doc_inline_conflict_29: [missing] -> pass (J0)
  • errors::verify_passes_doc_inline_only_use_29: pass -> [missing] (J0)
  • errors::verify_passes_doc_invalid_43: [missing] -> pass (J0)
  • errors::verify_passes_doc_keyword_not_mod_24: pass -> [missing] (J0)
  • errors::verify_passes_doc_masked_only_extern_crate_31: [missing] -> pass (J0)
  • errors::verify_passes_doc_search_unbox_invalid_28: [missing] -> pass (J0)
  • errors::verify_passes_doc_test_literal_35: [missing] -> pass (J0)
  • errors::verify_passes_doc_test_takes_list_36: [missing] -> pass (J0)
  • errors::verify_passes_doc_test_unknown_33: pass -> [missing] (J0)
  • errors::verify_passes_doc_test_unknown_any_37: pass -> [missing] (J0)
  • errors::verify_passes_doc_test_unknown_spotlight_39: [missing] -> pass (J0)
  • errors::verify_passes_duplicate_diagnostic_item_in_crate_83: pass -> [missing] (J0)
  • errors::verify_passes_duplicate_diagnostic_item_in_crate_84: [missing] -> pass (J0)
  • errors::verify_passes_extern_main_98: pass -> [missing] (J0)
  • errors::verify_passes_has_incoherent_inherent_impl_43: pass -> [missing] (J0)
  • errors::verify_passes_implied_feature_not_exist_119: [missing] -> pass (J0)
  • errors::verify_passes_incorrect_crate_type_100: pass -> [missing] (J0)
  • errors::verify_passes_incorrect_target_99: pass -> [missing] (J0)
  • errors::verify_passes_ineffective_unstable_impl_129: pass -> [missing] (J0)
  • errors::verify_passes_invalid_macro_export_arguments_too_many_items_67: [missing] -> pass (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_80: pass -> [missing] (J0)
  • errors::verify_passes_lang_item_fn_with_target_feature_81: [missing] -> pass (J0)
  • errors::verify_passes_layout_abi_84: pass -> [missing] (J0)
  • errors::verify_passes_layout_align_85: pass -> [missing] (J0)
  • errors::verify_passes_layout_homogeneous_aggregate_87: pass -> [missing] (J0)
  • errors::verify_passes_layout_invalid_attribute_89: pass -> [missing] (J0)
  • errors::verify_passes_layout_of_88: pass -> [missing] (J0)
  • errors::verify_passes_link_46: pass -> [missing] (J0)
  • errors::verify_passes_macro_export_63: pass -> [missing] (J0)
  • errors::verify_passes_macro_export_on_decl_macro_64: pass -> [missing] (J0)
  • errors::verify_passes_macro_only_attribute_57: [missing] -> pass (J0)
  • errors::verify_passes_may_dangle_68: pass -> [missing] (J0)
  • errors::verify_passes_missing_const_err_121: [missing] -> pass (J0)
  • errors::verify_passes_missing_panic_handler_77: [missing] -> pass (J0)
  • errors::verify_passes_missing_stability_attr_113: pass -> [missing] (J0)
  • errors::verify_passes_multiple_rustc_main_98: [missing] -> pass (J0)
  • errors::verify_passes_must_not_suspend_46: [missing] -> pass (J0)
  • errors::verify_passes_no_link_48: [missing] -> pass (J0)
  • errors::verify_passes_object_lifetime_err_103: pass -> [missing] (J0)
  • errors::verify_passes_object_lifetime_err_104: [missing] -> pass (J0)
  • errors::verify_passes_panic_unwind_without_std_78: [missing] -> pass (J0)
  • errors::verify_passes_proc_macro_bad_sig_122: pass -> [missing] (J0)
  • errors::verify_passes_repr_align_greater_than_target_max_55: [missing] -> pass (J0)
  • errors::verify_passes_repr_align_should_be_align_141: pass -> [missing] (J0)
  • errors::verify_passes_repr_conflicting_54: [missing] -> pass (J0)
  • errors::verify_passes_rustc_dirty_clean_52: pass -> [missing] (J0)
  • errors::verify_passes_rustc_force_inline_coro_62: pass -> [missing] (J0)
  • errors::verify_passes_rustc_force_inline_coro_63: [missing] -> pass (J0)
  • errors::verify_passes_rustc_legacy_const_generics_index_exceed_50: pass -> [missing] (J0)
  • errors::verify_passes_rustc_legacy_const_generics_index_negative_51: pass -> [missing] (J0)
  • errors::verify_passes_rustc_legacy_const_generics_index_negative_52: [missing] -> pass (J0)
  • errors::verify_passes_rustc_legacy_const_generics_only_48: pass -> [missing] (J0)
  • errors::verify_passes_rustc_lint_opt_deny_field_access_72: pass -> [missing] (J0)
  • errors::verify_passes_rustc_lint_opt_ty_71: pass -> [missing] (J0)
  • errors::verify_passes_rustc_lint_opt_ty_72: [missing] -> pass (J0)
  • errors::verify_passes_sanitize_attribute_not_allowed_132: [missing] -> pass (J0)
  • errors::verify_passes_transparent_incompatible_109: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_adt_with_private_fields_141: [missing] -> pass (J0)
  • errors::verify_passes_unexportable_generic_fn_135: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_item_134: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_priv_item_139: pass -> [missing] (J0)
  • errors::verify_passes_unexportable_type_repr_137: pass -> [missing] (J0)
  • errors::verify_passes_unknown_lang_item_83: [missing] -> pass (J0)
  • errors::verify_passes_unnecessary_partial_stable_feature_128: pass -> [missing] (J0)
  • errors::verify_passes_unnecessary_partial_stable_feature_129: [missing] -> pass (J0)
  • errors::verify_passes_unnecessary_stable_feature_128: [missing] -> pass (J0)
  • errors::verify_passes_unreachable_due_to_uninhabited_123: pass -> [missing] (J0)
  • errors::verify_passes_unreachable_due_to_uninhabited_124: [missing] -> pass (J0)
  • errors::verify_passes_unstable_attr_for_already_stable_feature_112: pass -> [missing] (J0)
  • errors::verify_passes_unsupported_attributes_in_where_134: [missing] -> pass (J0)
  • errors::verify_passes_unused_assign_passed_130: pass -> [missing] (J0)
  • errors::verify_passes_unused_duplicate_69: pass -> [missing] (J0)
  • errors::verify_passes_unused_multiple_71: [missing] -> pass (J0)
  • errors::verify_passes_useless_stability_110: pass -> [missing] (J0)
  • errors::verify_passes_useless_stability_111: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/invalid-attribute.rs: [missing] -> pass (J3)
  • [ui] tests/ui/sanitizer/cfi/no_builtins.rs: [missing] -> pass (J3)

Stage 2

  • [rustdoc-json] tests/rustdoc-json/doc_attribute.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/invalid-attribute.rs: [missing] -> pass (J1)
  • [ui] tests/ui/sanitizer/cfi/no_builtins.rs: [missing] -> pass (J2)

(and 154 additional test diffs)

Additionally, 76 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
 test-dashboard f2824da98d44c4a4e17bf39eb45103c8fc249117 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1392.5s -> 1762.8s (26.6%)
  2. x86_64-gnu-llvm-19: 2460.4s -> 2878.4s (17.0%)
  3. dist-aarch64-msvc: 5561.4s -> 6234.3s (12.1%)
  4. x86_64-gnu-nopt: 8357.4s -> 7423.0s (-11.2%)
  5. x86_64-gnu-llvm-20-3: 6484.8s -> 7122.8s (9.8%)
  6. aarch64-gnu-llvm-19-2: 2358.7s -> 2581.0s (9.4%)
  7. dist-android: 2491.7s -> 2650.3s (6.4%)
  8. x86_64-gnu-llvm-19-1: 3578.2s -> 3355.3s (-6.2%)
  9. x86_64-gnu-llvm-20-2: 5898.0s -> 6244.3s (5.9%)
  10. x86_64-gnu-tools: 3601.4s -> 3811.8s (5.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
Prepare workflow directory
Prepare all required actions
Getting action download info
Download action repository 'actions/checkout@v5' (SHA:08c6903cd8c0fde910a37f88322edcfb5dd907a8)
Complete job name: DockerHub mirror
##[group]Run actions/checkout@v5
with:
 persist-credentials: false
 repository: rust-lang/rust
 token: ***
---
http.https://github.com/.extraheader
[command]/usr/bin/git config --local --unset-all http.https://github.com/.extraheader
[command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.https\:\/\/github\.com\/\.extraheader' && git config --local --unset-all 'http.https://github.com/.extraheader' || :"
##[endgroup]
##[group]Run echo "***" | docker login ghcr.io -u rust-lang --password-stdin
echo "***" | docker login ghcr.io -u rust-lang --password-stdin
shell: /usr/bin/bash -e {0}
##[endgroup]
Error response from daemon: Get "https://ghcr.io/v2/": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
Post job cleanup.

Copy link
Collaborator

Finished benchmarking commit (f2824da): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.4% [-0.9%, -0.1%] 32
Improvements ✅
(secondary)		 -0.5% [-0.9%, -0.1%] 10
All ❌✅ (primary) -0.4% [-0.9%, -0.1%] 32

Max RSS (memory usage)

Results (primary -2.1%, secondary 1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)		 -2.1% [-3.1%, -1.1%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.1% [-3.1%, -1.1%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.374s -> 467.655s (0.27%)
Artifact size: 388.50 MiB -> 388.50 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[...]`, `#![...]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-json Area: Rustdoc JSON backend A-rustdoc-search Area: Rustdoc's search feature merged-by-bors This PR was explicitly merged by bors. PG-exploit-mitigations Project group: Exploit mitigations rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /