-
Notifications
You must be signed in to change notification settings - Fork 13.7k
rustdoc: [PoC] [WIP] Don't render keyword Self
as SelfTy
#145806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fmease
fmease
added
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
S-experimental
Status: Ongoing experiment that does not require reviewing and won't be merged in its current state.
rla-silenced
Silences rust-log-analyzer postings to the PR it's added on.
labels
Aug 24, 2025
@rustbot
rustbot
added
A-attributes
Area: Attributes (`#[...]`, `#![...]`)
A-rustdoc-json
Area: Rustdoc JSON backend
A-rustdoc-search
Area: Rustdoc's search feature
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-rustdoc-frontend
Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
labels
Aug 24, 2025
@fmease
fmease
removed
the
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 24, 2025
☔ The latest upstream changes (presumably #145970) made this pull request unmergeable. Please resolve the merge conflicts.
@bors
bors
added
the
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Really dirty mockup, somewhat broken, too. Inspired by this Reddit post.
Of course, there would be a much simpler quite obvious fix of just hardcoding the Self|->SelfTy mapping. I'm trying to avoid that right now because that'd be really unprincipled. Anyways, let's see how my current approach fares or if I'll push myself to fix the overarching letter casing issue once and forall instead.
Fixes #98828.