-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Instantiate predicate binder without recanonicalizing goal in new solver #136997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rustbot
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
WG-trait-system-refactor
The Rustc Trait System Refactor Initiative (-Znext-solver)
labels
Feb 14, 2025
lcnr
lcnr
reviewed
Feb 14, 2025
@@ -28,5 +29,5 @@ impl<V> Trait<u16, V> for () {}
fn impls_trait<T: Trait<U, V>, U: Id<V>, V>() {}
fn main() {
impls_trait::<(), _, _>()
//~^ ERROR type annotations needed
//[old]~^ ERROR type annotations needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test should be changed to have one step of indirection between the binder and the LeakCheckFailure bound.
hmm 👍 one concern is that this also impacts coherence, so it affects stable.
would need an FCP (and it seems generally useful to explain this to the other types team members, if only to fully reason about this ourselves). I would be fine writing the FCP comment, but would finish some other work first, so it'd take a while
☔ The latest upstream changes (presumably #139595) made this pull request unmergeable. Please resolve the merge conflicts.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 5, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 [first perf run](rust-lang#133502 (comment)) 👻 ### crater This does not detect hangs or memory issues. | date | #crates | #regressions | | ---- | ------- | ------------ | | 2025年04月11日 | 100 | 2 | | 2025年04月11日 | 1000 | 27 | | 2025年04月17日 | 10000 | 456 | | 2025年04月18日 | 10000 | 437 | | 2025年04月24日 | 10000 | 164 | | 2025年04月26日 | 10000 | 108 | | 2025年04月28日 | 10000 | 91 | | 2025年05月01日 | 10000 | 145 woops | | 2025年05月03日 | 624228[^1] | 1585 | | 2025年05月05日 | 8964[^2] | 931 | [^1]: a complete crater run [^2]: only testing crates which may have regressed from the above run ### in-flight changes - rust-lang#140561 - rust-lang#140672 - rust-lang#140678 - rust-lang#136997 - rust-lang#139587 - rust-lang#140497 - rust-lang#124852, unsure whether I actually want to land this PR for now - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140260 - rust-lang#140375 - rust-lang#140405 - rust-lang#140496 - double recursion limit in the new solver r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 [first perf run](rust-lang#133502 (comment)) 👻 ### crater This does not detect hangs or memory issues. | date | #crates | #regressions | | ---- | ------- | ------------ | | 2025年04月11日 | 100 | 2 | | 2025年04月11日 | 1000 | 27 | | 2025年04月17日 | 10000 | 456 | | 2025年04月18日 | 10000 | 437 | | 2025年04月24日 | 10000 | 164 | | 2025年04月26日 | 10000 | 108 | | 2025年04月28日 | 10000 | 91 | | 2025年05月01日 | 10000 | 145 woops | | 2025年05月03日 | 624228[^1] | 1585 | | 2025年05月05日 | 8964[^2] | 931 | [^1]: a complete crater run [^2]: only testing crates which may have regressed from the above run ### in-flight changes - rust-lang#140561 - rust-lang#140672 - rust-lang#140678 - rust-lang#136997 - rust-lang#139587 - rust-lang#140497 - rust-lang#124852, unsure whether I actually want to land this PR for now - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140260 - rust-lang#140375 - rust-lang#140405 - rust-lang#140496 - double recursion limit in the new solver r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 [first perf run](rust-lang#133502 (comment)) 👻 ### crater This does not detect hangs or memory issues. | date | #crates | #regressions | | ---- | ------- | ------------ | | 2025年04月11日 | 100 | 2 | | 2025年04月11日 | 1000 | 27 | | 2025年04月17日 | 10000 | 456 | | 2025年04月18日 | 10000 | 437 | | 2025年04月24日 | 10000 | 164 | | 2025年04月26日 | 10000 | 108 | | 2025年04月28日 | 10000 | 91 | | 2025年05月01日 | 10000 | 145 woops | | 2025年05月03日 | 624228[^1] | 1585 | | 2025年05月05日 | 8964[^2] | 931 | | 2025年05月06日 | 4401[^2] | 726 | [^1]: a complete crater run [^2]: only testing crates which may have regressed from the above run ### in-flight changes - rust-lang#140561 - rust-lang#140672 - rust-lang#140678 - rust-lang#136997 - rust-lang#139587 - rust-lang#140497 - rust-lang#124852, unsure whether I actually want to land this PR for now - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140260 - rust-lang#140375 - rust-lang#140405 - rust-lang#140496 - double recursion limit in the new solver r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 6, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 [first perf run](rust-lang#133502 (comment)) 👻 ### crater This does not detect hangs or memory issues. | date | #crates | #regressions | | ---- | ------- | ------------ | | 2025年04月11日 | 100 | 2 | | 2025年04月11日 | 1000 | 27 | | 2025年04月17日 | 10000 | 456 | | 2025年04月18日 | 10000 | 437 | | 2025年04月24日 | 10000 | 164 | | 2025年04月26日 | 10000 | 108 | | 2025年04月28日 | 10000 | 91 | | 2025年05月01日 | 10000 | 145 woops | | 2025年05月03日 | 624228[^1] | 1585 | | 2025年05月05日 | 8964[^2] | 931 | | 2025年05月06日 | 4401[^2] | 726 | [^1]: a complete crater run [^2]: only testing crates which may have regressed from the above run ### in-flight changes - rust-lang#140561 - rust-lang#140672 - rust-lang#140678 - rust-lang#136997 - rust-lang#139587 - rust-lang#140497 - rust-lang#124852, unsure whether I actually want to land this PR for now - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140260 - rust-lang#140375 - rust-lang#140405 - rust-lang#140496 - double recursion limit in the new solver r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 [first perf run](rust-lang#133502 (comment)) 👻 ### crater This does not detect hangs or memory issues. | date | #crates | #regressions | | ---- | ------- | ------------ | | 2025年04月11日 | 100 | 2 | | 2025年04月11日 | 1000 | 27 | | 2025年04月17日 | 10000 | 456 | | 2025年04月18日 | 10000 | 437 | | 2025年04月24日 | 10000 | 164 | | 2025年04月26日 | 10000 | 108 | | 2025年04月28日 | 10000 | 91 | | 2025年05月01日 | 10000 | 145 woops | | 2025年05月03日 | 624228[^1] | 1585 | | 2025年05月05日 | 8964[^2] | 931 | | 2025年05月06日 | 4401[^2] | 726 | [^1]: a complete crater run [^2]: only testing crates which may have regressed from the above run ### in-flight changes - rust-lang#140711 - rust-lang#140713 - rust-lang#140712 - rust-lang#136997 - rust-lang#139587 - rust-lang#140497 - rust-lang#124852, unsure whether I actually want to land this PR for now - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140260 - rust-lang#140375 - rust-lang#140405 - look into blanket impls for opaque type infer vars as well - rust-lang#140496 - double recursion limit in the new solver r? `@ghost`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2025
[DO NOT MERGE] bootstrap with `-Znext-solver=globally` A revival of rust-lang#124812. Current status: ~~`./x.py b --stage 2` passes 🎉~~ `try` builds succeed 🎉 🎉 🎉 [first perf run](rust-lang#133502 (comment)) 👻 ### crater This does not detect hangs or memory issues. | date | #crates | #regressions | | ---- | ------- | ------------ | | 2025年04月11日 | 100 | 2 | | 2025年04月11日 | 1000 | 27 | | 2025年04月17日 | 10000 | 456 | | 2025年04月18日 | 10000 | 437 | | 2025年04月24日 | 10000 | 164 | | 2025年04月26日 | 10000 | 108 | | 2025年04月28日 | 10000 | 91 | | 2025年05月01日 | 10000 | 145 woops | | 2025年05月03日 | 624228[^1] | 1585 | | 2025年05月05日 | 8964[^2] | 931 | | 2025年05月06日 | 4401[^2] | 726 | | 2025年05月07日 | 2704[^2] | 668 | [^1]: a complete crater run [^2]: only testing crates which may have regressed from the above run ### in-flight changes - rust-lang#140712 - rust-lang#136997 - rust-lang#139587 - rust-lang#140497 - rust-lang#124852, unsure whether I actually want to land this PR for now - https://github.com/lcnr/rust/tree/opaque-type-method-call - rust-lang#140375 - rust-lang#140405 - look into blanket impls for opaque type infer vars as well - rust-lang#140496 - double recursion limit in the new solver r? `@ghost`
I wonder how much this affects perf...
@bors try @rust-timer queue
This comment has been minimized.
This comment has been minimized.
@rustbot
rustbot
added
the
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Jun 2, 2025
bors
added a commit
that referenced
this pull request
Jun 2, 2025
Instantiate predicate binder without recanonicalizing goal in new solver This has the side-effect of making the leak check stronger. r? lcnr
☀️ Try build successful - checks-actions
Build commit: 2f79182 (2f79182e4fecd8940876615a520ef94f9ae67a5b)
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (2f79182): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (secondary 0.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 743.462s -> 741.168s (-0.31%) |
@rustbot
rustbot
removed
the
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Jun 2, 2025
okay, looks like my expectation that recanonicalizing after instantiating the binder being better for caching does not actually hold 😁
so there's pretty much no reason to not land this change :3
@lcnr
lcnr
added
the
needs-fcp
This change is insta-stable, or significant enough to need a team FCP to proceed.
label
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the side-effect of making the leak check stronger.
r? lcnr