Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[DO NOT MERGE] bootstrap with -Znext-solver=globally #133502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lcnr wants to merge 17 commits into rust-lang:master
base: master
Choose a base branch
Loading
from lcnr:rust4

Conversation

Copy link
Contributor

@lcnr lcnr commented Nov 26, 2024 •
edited
Loading

A revival of #124812.

Current status:

(削除) ./x.py b --stage 2 passes 🎉 (削除ここまで)

try builds succeed 🎉 🎉 🎉

first perf run 👻

crater

This does not detect hangs or memory issues.

date #crates #regressions
2025年04月11日 100 2
2025年04月11日 1000 27
2025年04月17日 10000 456
2025年04月18日 10000 437
2025年04月24日 10000 164
2025年04月26日 10000 108
2025年04月28日 10000 91
2025年05月01日 10000 145 woops
2025年05月03日 6242281 1585
2025年05月05日 89642 931
2025年05月06日 44012 726
2025年05月07日 27042 668
2025年05月09日 23452 664

in-flight changes

r? @ghost

Footnotes

  1. a complete crater run ↩

  2. only testing crates which may have regressed from the above run ↩ ↩2 ↩3 ↩4

yoshuawuyts, Enselic, yerke, rrbutani, ben0x539, CGMossa, jplatte, Kobzol, cynecx, oriongonza, and 14 more reacted with hooray emoji saethlin, quat1024, TheBestTvarynka, jieyouxu, and Nadrieril reacted with eyes emoji
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 26, 2024

This comment has been minimized.

Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2024 
[DO NOT MERGE] bootstrap with `-Znext-solver=globally`
A revival of rust-lang#124812.
Current status, we're failing in:
- failing in `rustc_next_trait_solver` with 126 instances of the following error
```
error[E0311]: the parameter type `I` may not live long enough
 |
help: consider adding an explicit lifetime bound
 --> compiler/rustc_next_trait_solver/src/solve/trait_goals.rs:624:53
 |
624 ~ fn consider_structural_builtin_unsize_candidates<'a>(
625 ~ ecx: &mut EvalCtxt<'a, D>,
626 | goal: Goal<I, Self>,
627 ~ ) -> Vec<Candidate<I>> where I: 'a {
```
- `itertools` hangs, we're already encountered this hang in our previous attempt due to large type sizes. I believe that it's simply caused by a missing cache somewhere, potentially in `wf.rs`, but other visitors may also be responsible. See rust-itertools/itertools#945 for more details
### commits
- rust-lang#133501
- rust-lang#133493
- 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR
- c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now
r? `@ghost`
Copy link
Collaborator

bors commented Nov 27, 2024

⌛ Trying commit f631ca8 with merge ca04381...

Copy link
Member

This comment was marked as off-topic.

This comment has been minimized.

Copy link
Collaborator

bors commented Nov 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2024
Copy link
Collaborator

bors commented Nov 27, 2024

☔ The latest upstream changes (presumably #133527) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

lqd commented Nov 27, 2024 •
edited
Loading

Next failure is on color-print-proc-macro-0.3.6 while building cargo.

thesignal 

pub fn repro() -> impl FnMut() {
 if true {
 || ()
 } else {
 || ()
 }
}

godbolt

lcnr, compiler-errors, workingjubilee, and Noratrieb reacted with heart emoji

Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2024 
[DO NOT MERGE] bootstrap with `-Znext-solver=globally`
A revival of rust-lang#124812.
Current status:
`./x.py b --stage 2` passes 🎉
### commits
- rust-lang#133501
- rust-lang#133493
- 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR
- c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now
- rust-lang#133517
* rust-lang#133518
* rust-lang#133519
* rust-lang#133520
* rust-lang#133521
* rust-lang#133524
r? `@ghost`
Copy link
Collaborator

bors commented Nov 27, 2024

⌛ Trying commit 6210ed3 with merge ac5ccad...

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

bors commented Nov 27, 2024

💔 Test failed - checks-actions

Copy link
Member

@bors try
lqd reacted with thumbs up emoji

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2024 
[DO NOT MERGE] bootstrap with `-Znext-solver=globally`
A revival of rust-lang#124812.
Current status:
`./x.py b --stage 2` passes 🎉
### commits
- rust-lang#133501
- rust-lang#133493
- 9456bfe and b21b116 reimplement candidate preference based on rust-lang#132325, not yet a separate PR
- c3ef9cd is a rebased version of rust-lang#125334, unsure whether I actually want to land this PR for now
- rust-lang#133517
* rust-lang#133518
* rust-lang#133519
* rust-lang#133520
* rust-lang#133521
* rust-lang#133524
r? `@ghost`
Copy link
Collaborator

bors commented Nov 27, 2024

⌛ Trying commit 8fa8f40 with merge 550ae0d...

Copy link
Member

lqd commented Nov 27, 2024

I was reducing the new failure but you've already fixed it ^^
compiler-errors reacted with heart emoji

This comment has been minimized.

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 14, 2025
Copy link
Member

@rust-timer build 3cddd79

This comment has been minimized.

Copy link
Collaborator

Finished benchmarking commit (3cddd79): comparison URL.

Overall result: ❌✅ regressions and improvements - BENCHMARK(S) FAILED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

❗ ❗ ❗ ❗ ❗
Warning ⚠️: The following benchmark(s) failed to build:

  • wg-grammar

❗ ❗ ❗ ❗ ❗

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)		 163.8% [0.2%, 12464.4%] 298
Regressions ❌
(secondary)		 368.9% [0.2%, 14257.5%] 214
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.4%] 4
Improvements ✅
(secondary)		 -5.9% [-19.1%, -0.2%] 11
All ❌✅ (primary) 161.6% [-0.6%, 12464.4%] 302

Max RSS (memory usage)

Results (primary 5.9%, secondary 38.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 10.9% [0.4%, 76.9%] 98
Regressions ❌
(secondary)		 59.1% [1.1%, 358.9%] 27
Improvements ✅
(primary)		 -1.8% [-8.2%, -0.4%] 64
Improvements ✅
(secondary)		 -4.2% [-8.0%, -0.9%] 13
All ❌✅ (primary) 5.9% [-8.2%, 76.9%] 162

Cycles

Results (primary 149.5%, secondary 516.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 149.5% [0.4%, 9418.3%] 231
Regressions ❌
(secondary)		 541.4% [1.4%, 13945.3%] 131
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -21.6% [-32.8%, -6.5%] 6
All ❌✅ (primary) 149.5% [0.4%, 9418.3%] 231

Binary size

Results (primary -0.0%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 1
Improvements ✅
(secondary)		 -0.1% [-0.1%, -0.1%] 6
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 1

Bootstrap: 771.655s -> 1026.817s (33.07%)
Artifact size: 365.39 MiB -> 359.16 MiB (-1.70%)
mati865 reacted with laugh emoji mati865 reacted with eyes emoji

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 14, 2025
lcnr and others added 17 commits May 21, 2025 11:29 
While still only using them for diagnostics. We could use them for cycle
detection in generalization and it seems desirable to do so in the future.
However, this is unsound with the old trait solver as its cache does not track
these `sub_relations` in any way. We would also need to consider them
when canonicalizing as otherwise instantiating the canonical response may
fail.
Copy link
Collaborator

The job mingw-check-tidy failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
info: removing rustup binaries
info: rustup is uninstalled
##[group]Image checksum input
mingw-check-tidy
# We use the ghcr base image because ghcr doesn't have a rate limit
# and the mingw-check-tidy job doesn't cache docker images in CI.
FROM ghcr.io/rust-lang/ubuntu:22.04
ARG DEBIAN_FRONTEND=noninteractive
RUN apt-get update && apt-get install -y --no-install-recommends \
 g++ \
---
COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
COPY host-x86_64/mingw-check/validate-error-codes.sh /scripts/
# NOTE: intentionally uses python2 for x.py so we can test it still works.
# validate-toolstate only runs in our CI, so it's ok for it to only support python3.
ENV SCRIPT TIDY_PRINT_DIFF=1 python2.7 ../x.py test \
 --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
#
# This file is autogenerated by pip-compile with Python 3.10
# by the following command:
#
# pip-compile --allow-unsafe --generate-hashes reuse-requirements.in
---
#12 2.903 Building wheels for collected packages: reuse
#12 2.904 Building wheel for reuse (pyproject.toml): started
#12 3.119 Building wheel for reuse (pyproject.toml): finished with status 'done'
#12 3.120 Created wheel for reuse: filename=reuse-4.0.3-cp310-cp310-manylinux_2_35_x86_64.whl size=132719 sha256=d2a2565e7037ad3883fb9337653f2e25bbb588534fbef3697286cbc26d1bf634
#12 3.120 Stored in directory: /tmp/pip-ephem-wheel-cache-vowxs868/wheels/3d/8d/0a/e0fc6aba4494b28a967ab5eaf951c121d9c677958714e34532
#12 3.122 Successfully built reuse
#12 3.123 Installing collected packages: boolean-py, binaryornot, tomlkit, reuse, python-debian, markupsafe, license-expression, jinja2, chardet, attrs
#12 3.519 Successfully installed attrs-23.2.0 binaryornot-0.4.4 boolean-py-4.0 chardet-5.2.0 jinja2-3.1.4 license-expression-30.3.0 markupsafe-2.1.5 python-debian-0.1.49 reuse-4.0.3 tomlkit-0.13.0
#12 3.519 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 4.069 Collecting virtualenv
#12 4.117 Downloading virtualenv-20.31.2-py3-none-any.whl (6.1 MB)
#12 4.344 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.1/6.1 MB 27.1 MB/s eta 0:00:00
#12 4.389 Collecting distlib<1,>=0.3.7
#12 4.396 Downloading distlib-0.3.9-py2.py3-none-any.whl (468 kB)
#12 4.407 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 469.0/469.0 KB 53.0 MB/s eta 0:00:00
#12 4.445 Collecting platformdirs<5,>=3.9.1
#12 4.453 Downloading platformdirs-4.3.8-py3-none-any.whl (18 kB)
#12 4.494 Collecting filelock<4,>=3.12.2
#12 4.501 Downloading filelock-3.18.0-py3-none-any.whl (16 kB)
#12 4.582 Installing collected packages: distlib, platformdirs, filelock, virtualenv
#12 4.773 Successfully installed distlib-0.3.9 filelock-3.18.0 platformdirs-4.3.8 virtualenv-20.31.2
#12 4.774 WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
#12 DONE 4.9s
#13 [7/8] COPY host-x86_64/mingw-check/validate-toolstate.sh /scripts/
#13 DONE 0.0s
---
DirectMap4k: 155584 kB
DirectMap2M: 8232960 kB
DirectMap1G: 10485760 kB
##[endgroup]
Executing TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
+ TIDY_PRINT_DIFF=1 python2.7 ../x.py test --stage 0 src/tools/tidy tidyselftest --extra-checks=py,cpp
##[group]Building bootstrap
 Finished `dev` profile [unoptimized] target(s) in 0.05s
##[endgroup]
WARN: currently no CI rustc builds have rustc debug assertions enabled. Please either set `rust.debug-assertions` to `false` if you want to use download CI rustc or set `rust.download-rustc` to `false`.
downloading https://static.rust-lang.org/dist/2025-05-12/rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
---
fmt check
fmt: checked 6018 files
tidy check
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs:911: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_next_trait_solver/src/solve/assembly/mod.rs:942: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
tidy error: /checkout/tests/ui/nll/member-constraints/non-root-universe-existential-1.rs: too many trailing newlines (3)
##[error]tidy error: /checkout/compiler/rustc_borrowck/src/region_infer/opaque_types.rs:420: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
##[error]tidy error: /checkout/compiler/rustc_borrowck/src/region_infer/opaque_types.rs:477: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.1.1)
linting python files
All checks passed!
checking python file formatting
26 files already formatted
checking C++ file formatting
some tidy checks failed
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:50
 local time: Wed May 21 11:40:37 UTC 2025
 network time: 2025年5月21日 11:40:37 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

Copy link
Collaborator

bors commented May 24, 2025

☔ The latest upstream changes (presumably #141506) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[...]`, `#![...]`) A-compiletest Area: The compiletest test runner A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool perf-regression Performance regression. PG-exploit-mitigations Project group: Exploit mitigations S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /