Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs(style): add more let-else examples #110426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 1 commit into rust-lang:master from calebcartwright:style-let-else-examples
Apr 27, 2023

Conversation

Copy link
Member

@calebcartwright calebcartwright commented Apr 16, 2023

Adding a few more examples for increased clarity based on subsequent discussion that arose after implementation work began.

Will need approval from t-style, but also cc @ytmimi to make sure these examples don't contradict any examples we've been incorporating as part of the rustfmt implementation

Copy link
Collaborator

rustbot commented Apr 16, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-style Relevant to the style team, which will review and decide on the PR/issue. labels Apr 16, 2023
Copy link
Collaborator

rustbot commented Apr 16, 2023

Some changes occurred in src/doc/style-guide

cc @rust-lang/style

Copy link
Member

Thanks. These examples look good.

@bors r+ rollup

Copy link
Collaborator

bors commented Apr 26, 2023

📌 Commit 0776a4b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 26, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 26, 2023
...mples, r=compiler-errors
docs(style): add more let-else examples
Adding a few more examples for increased clarity based on subsequent discussion that arose after implementation work began.
Will need approval from t-style, but also cc `@ytmimi` to make sure these examples don't contradict any examples we've been incorporating as part of the rustfmt implementation
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 27, 2023
...mples, r=compiler-errors
docs(style): add more let-else examples
Adding a few more examples for increased clarity based on subsequent discussion that arose after implementation work began.
Will need approval from t-style, but also cc ``@ytmimi`` to make sure these examples don't contradict any examples we've been incorporating as part of the rustfmt implementation
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2023
...iaskrgr
Rollup of 7 pull requests
Successful merges:
 - rust-lang#110426 (docs(style): add more let-else examples)
 - rust-lang#110804 (Remove repeated definite articles)
 - rust-lang#110814 (Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`)
 - rust-lang#110816 (Migrate `rustc_passes` to translatable diagnostics)
 - rust-lang#110864 (`IntoFuture::into_future` is no longer unstable)
 - rust-lang#110866 (Make `method-not-found-generic-arg-elision.rs` error message not path dependent)
 - rust-lang#110872 (Nicer ICE for rust-lang#67981)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c2a79fb into rust-lang:master Apr 27, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@ytmimi ytmimi ytmimi left review comments

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-style Relevant to the style team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /