-
Notifications
You must be signed in to change notification settings - Fork 45
fix!: Take in byte spans #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This switches from char spans to byte spans
epage
epage
reviewed
Mar 8, 2024
@Muscraft
Muscraft
force-pushed
the
use-bytes
branch
from
March 8, 2024 16:36
d858aa9 to
083dedb
Compare
BREAKING CHANGE: This changes (usize, usize) into Range<usize>
@Muscraft
Muscraft
force-pushed
the
use-bytes
branch
from
March 8, 2024 20:35
083dedb to
c3bd0c3
Compare
epage
epage
approved these changes
Mar 8, 2024
This was referenced Mar 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This switches from char spans to byte spans
This PR is a draft implementation to address #77. While I think I fixed every issue in moving from char spans to byte spans, I am not entirely certain. I may look into adding more tests to ensure we are doing the write thing. This also doesn't address the fact that people could pass in char spans when updating the version, not realizing the change. We could do something to make it more apparent but I am not sure what that would be.