Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Source annotate ranges should use bytes not chars #77

Closed
Labels
M-breaking-changeMeta: Implementing or merging this will introduce a breaking change
Milestone
@Muscraft

Description

Currently, SourceAnnotation's range field is based on chars, not bytes. This can be a little confusing for users and can cause issues when dealing with spans from things like toml errors. It would make more sense to have users give us bytes, and we calculate the char spans internally. This would make the API easier to use as most people can handle going to bytes, but going from bytes -> chars can be very hard.

Metadata

Metadata

Assignees

No one assigned

    Labels

    M-breaking-changeMeta: Implementing or merging this will introduce a breaking change

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      AltStyle によって変換されたページ (->オリジナル) /