-
Notifications
You must be signed in to change notification settings - Fork 752
Fix test failures #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix test failures #1326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ahangarha next thing to try would be to use headless=new, based on SeleniumHQ/selenium#13112
This reverts commit 5311cbe.
@ahangarha
ahangarha
changed the title
(削除) WIP - Test exisitng situation (削除ここまで)
(追記) WIP - Fix test failures (追記ここまで)
Jan 2, 2024
@ahangarha
ahangarha
force-pushed
the
fix-tests-failure
branch
from
January 2, 2024 14:49
f524b24 to
d196d33
Compare
@ahangarha
ahangarha
changed the title
(削除) WIP - Fix test failures (削除ここまで)
(追記) Fix test failures (追記ここまで)
Jan 2, 2024
3 tasks
See #1328 (comment) - this looks like the fix for after updating selenium-webdriver but it still means the lockfiles are actually incorrect for Ruby 2.7, so I think we should land #1328 first then land this after a rebase + redoing the general update from #1302
3 tasks
If the issue is resolved (it seems it is) I close this PR.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR fixes some of the recent test failures.
Other Information
The change is based on the discussions in SeleniumHQ/selenium#13112.
Pull Request checklist
(削除) Add/update test to cover these changes (削除ここまで)(削除) Update documentation (削除ここまで)(削除) Update CHANGELOG file (削除ここまで)