Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: support other js package managers #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 9 commits into reactjs:master from G-Rath:use-package_json
Jan 6, 2024
Merged

feat: support other js package managers #1306

justin808 merged 9 commits into reactjs:master from G-Rath:use-package_json
Jan 6, 2024

Conversation

Copy link
Contributor

@G-Rath G-Rath commented Sep 2, 2023
edited
Loading

Summary

See shakacode/shakapacker#349 and shakacode/shakapacker#195

Other Information

This is also passing CI in our rails-template.

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

Copy link
Collaborator

@G-Rath let me know when ready to merge and release.

@G-Rath G-Rath marked this pull request as ready for review December 7, 2023 22:27
Copy link
Collaborator

@ahangarha @G-Rath can I merge once CI passes?

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Contributor Author

G-Rath commented Jan 3, 2024

@justin808 this should be good to go!

ahangarha reacted with thumbs up emoji

@justin808 justin808 merged commit 4aa7fb1 into reactjs:master Jan 6, 2024
Copy link
Collaborator

@G-Rath Let me know if you need a release ASAP.

@G-Rath G-Rath deleted the use-package_json branch January 6, 2024 18:00
G-Rath added a commit to ackama/rails-template that referenced this pull request Jan 26, 2024
...#528)
[`react-rails` now supports other package
managers](reactjs/react-rails#1306) using
`package_json`, meaning it now defaults to `npm` if a package manager is
not explicitly set in `package.json`, causing a stray
`package-lock.json` to be created.
I've specified an exact version because currently `corepack` requires
that ([ranges are not yet
supported](nodejs/corepack#95)) but we're not
actually expecting anyone to be using `corepack` and we're definitely
not using it in production (not explicitly at least...) so in theory
this shouldn't cause problems and it means `package.json` conforms to
the JSON schema - it'll also help to flush out any potential problems
early before(/if) `corepack` becomes more mainstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justin808 justin808 justin808 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /