-
Notifications
You must be signed in to change notification settings - Fork 163
Update bower.json #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,21 @@ | ||
| { | ||
| "name": "react-router-bootstrap", | ||
| "version": "0.8.3", | ||
| "version": "0.13.2", | ||
| "description": "react-router and react-bootstrap compatible components", | ||
| "main": "lib/ReactRouterBootstrap.js", | ||
| "homepage": "https://github.com/mtscout6/react-router-bootstrap", | ||
| "homepage": "https://github.com/react-bootstrap/react-router-bootstrap", | ||
| "author": { | ||
| "name": "Matt Smith", | ||
| "email": "mtscout6@gmail.com" | ||
| }, | ||
| "license": "Apache License, Version 2.0", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git://github.com/mtscout6/react-router-bootstrap.git" | ||
| "url": "git://github.com/react-bootstrap/react-router-bootstrap.git" | ||
| }, | ||
| "dependencies": { | ||
| "react-router": "^0.11.6", | ||
| "react-bootstrap": "^0.13.2" | ||
| "react-bootstrap": ">=0.15", | ||
| "react-router": ">=0.13.1" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should classnames be added here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You don't have classnames set up as an external in your webpack config: https://github.com/react-bootstrap/react-router-bootstrap/blob/master/webpack.config.js#L22 Currently classnames just gets built into the distributed bundle and is not required as a bower dependency. I could update that if you want, but thought it was intentional. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Makes sense, I forgot about that. I'm not personally a bower user, what would you prefer? Your webpack/browserify/require process would be slimmer if it was a declared dependency. May be worth updating in react-bootstrap too then. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I stopped using bower for this package, actually, in part because of this issue, so I don't have an opinion on this any more. I just thought I'd try to close this issue since I was submitting the other PR as well. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good to me, we'll let someone that deals with bower submit a PR 😄 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW, thinking about this a little more - I think the status quo is okay. It's an extra 30 LOC, and the recent classnames major version upgrade means that embedding the dependency will let you avoid conflicts with other packages that specify classnames 1.x.x (since Bower uses flat dependencies rather than nested ones like NPM). But I agree that an actual Bower user should update this to something they consider sensible. |
||
| }, | ||
| "ignore": [ | ||
| "**/.*", | ||
|
|
||