-
Notifications
You must be signed in to change notification settings - Fork 163
Update bower.json #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you, do I need to tell bower about the move in any way?
I believe a transfer will require you to submit a ticket to the Bower registry repo, per: http://bower.io/docs/creating-packages/#register
For package name transfers, intellectual property and other disputes, please try to resolve with the owner first. If no resolution, please submit a ticket in the Bower Registry repo and the Bower Core Team will assist.
Alternatively, you can unregister and re-register the package.
Thanks I'll take care of that today.
Need one more sign off by a member of @react-bootstrap/collaborators
I unregistered and re-registered the repo with bower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be https://github.com/react-bootstrap/react-router-bootstrap
@mtscout6 looks good
@taion I just realize the urls are wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should classnames be added here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't have classnames set up as an external in your webpack config: https://github.com/react-bootstrap/react-router-bootstrap/blob/master/webpack.config.js#L22
Currently classnames just gets built into the distributed bundle and is not required as a bower dependency. I could update that if you want, but thought it was intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I forgot about that.
I'm not personally a bower user, what would you prefer? Your webpack/browserify/require process would be slimmer if it was a declared dependency. May be worth updating in react-bootstrap too then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stopped using bower for this package, actually, in part because of this issue, so I don't have an opinion on this any more. I just thought I'd try to close this issue since I was submitting the other PR as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me, we'll let someone that deals with bower submit a PR 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, thinking about this a little more - I think the status quo is okay. It's an extra 30 LOC, and the recent classnames major version upgrade means that embedding the dependency will let you avoid conflicts with other packages that specify classnames 1.x.x (since Bower uses flat dependencies rather than nested ones like NPM).
But I agree that an actual Bower user should update this to something they consider sensible.
Oops. Let's just forget I ever pushed the commit with the wrong URLs.
@taion And the classnames dependency?
See line comment above.
For #34