Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added Hello, World! example to Python, Rust, Javascript and C++ #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mathys-Gasnier merged 9 commits into quicksnip-dev:main from james-beans:main
Dec 30, 2024
Merged

Conversation

Copy link
Contributor

@james-beans james-beans commented Dec 29, 2024

I have added a Hello, World! example to all of the programming languages that I know have a printing function. This also might be a bit to beginners like for what you have already put on the languages.

Please tell me if I have messed something up. I think this should all be correct and working.

wneel and KovD3v reacted with hooray emoji
Copy link

netlify bot commented Dec 29, 2024
edited
Loading

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit d4a54ee
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/67730abf72096200082fff37
😎 Deploy Preview https://deploy-preview-17--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@wneel wneel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would maybe change the category name to something like "basics" or just "Hello World" but this is a great idea!

  • Idk if this is wanted or not but you just put a line break in the .cpp!

Copy link
Contributor Author

james-beans commented Dec 29, 2024
edited
Loading

  • Idk if this is wanted or not but you just put a line break in the .cpp!

Yeah if you were talking about under the import of the cpp implementation then yes there is supposed to be an empty line.

I would maybe change the category name to something like "basics" or just "Hello World" but this is a great idea!

I think that it being called "Terminal Output" is just fine on all of them apart from the JavaScript implementation because of it being used in a lot of other things other than just CLI terminal tools. Because of this, I might change the JavaScript snippet category name to just "Output" if that's ok.

wneel reacted with thumbs up emoji

changed the category name "terminal output" to just "output" in the category name of JavaScript.
Copy link
Collaborator

Hey, there. Thanks for the contribution.

Regarding your idea, I like it. I think we can change the category to "Basics" and include basic and handy code snippets in programming languages that doesn't belong to any category. Also, designed for those who are new to that programming language.

It would also keep it consistent across other languages as well. I'm open to listening more ideas as well.

wneel reacted with thumbs up emoji

@technoph1le technoph1le added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 30, 2024
Copy link
Contributor Author

james-beans commented Dec 30, 2024
edited
Loading

Regarding your idea, I like it. I think we can change the category to "Basics" and include basic and handy code snippets in programming languages that doesn't belong to any category. Also, designed for those who are new to that programming language.

I think that having it just called 'Basics' is a bit more general vs what it actually does which is terminal output.

Renaming it could make it a bit harder to organize snippets without another type of category that goes under another category (sub-categories). Adding a search feature for tags would be nice to have especially for snippets if we are going to make sub-categories.

@technoph1le technoph1le added discuss Needs to be discussed by community and removed help wanted Extra attention is needed labels Dec 30, 2024
Copy link
Collaborator

One idea would be to name the category "Beginners" just showing the minimal snippet of code needed to print an Hello World.
But calling it "Basics" is ok in my books too.

wneel reacted with thumbs up emoji

Copy link
Contributor Author

I added the fix for it to my forked version of this repo and it used to automatically add the changes but it hasn't seemed to update the latest commit to this? Can someone add it for me?

Copy link
Collaborator

Did you push ? I can't see the change on your repo so you probably forgot

Copy link
Contributor Author

I did commit it. It just didn't update for like 2 hours straight on this pr. It has now. Can you check if this is finally done so someone can push it?

Copy link
Collaborator

Before anything I would like you to changes the categories of the snippets you added, I think we came to a conclusion that a category named "Basics" fits better those snippets.

Copy link
Contributor Author

Before anything I would like you to changes the categories of the snippets you added, I think we came to a conclusion that a category named "Basics" fits better those snippets.

Ok ill change it. That does kind of sound like a good name now after thinking about it.

Copy link
Contributor Author

Done it! I might add more later but I will add to another pr instead.

wneel reacted with thumbs up emoji

@Mathys-Gasnier Mathys-Gasnier merged commit 0615529 into quicksnip-dev:main Dec 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mathys-Gasnier Mathys-Gasnier Mathys-Gasnier approved these changes

+1 more reviewer

@wneel wneel wneel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
discuss Needs to be discussed by community good first issue Good for newcomers Snippets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /