-
-
Notifications
You must be signed in to change notification settings - Fork 129
added nob.h support to quicksnip under new C category #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As far as I know nob.h doesn't have a logo yet so I put a base there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Thank you for your contribution.
After reviewing your PR we've found that all/some snippets you are adding don't match the scope of Quicksnip.
The snippet you are providing act more like examples. If you have any question or want to contest this decision please send a message in your PR explaining your position.
If no fix is provided within 7-10 days this PR will be closed without further notice
@Mathys-Gasnier Most code in quicksnip already are just examples of how someone would implement a function. My code is a config file not a function. If you actually looked at what library it is, you would understand. My code is also an example but so is everything else just in a different format. Thats basically what quicksnip is. A database/website full of examples on how to code things. So why exactly does my code not fit in?
I understand that I repeat things a lot. Please fix my English if it is wrong or mention if I have mentioned the same point more than once. Thank you.
We do not provide examples on how to use build systems, at least not for now.
Quicksnip aims to be a library of snippets, which are functions that can be copied in a project without hassle, with a small example of use attached.
Examples like those, aim to show how to use nob, and are more fit for it's documentation.
The scope of quicksnip might expand in the future.
But for now we wont add snippets that are examples of use of build systems/libraries.
FYI: I know what nob is, I followed it's development on tsoding streams.
But for now we wont add snippets that are examples of use of build systems/libraries.
Are you sure about the libraries part? There are libraries on quicksnip right now. Examples: React (React itself is a library for JS or TS), FastAPI (A Python library).
I understand now that it doesn't fit at the moment but that should be the thing with stuff like this. It is supposed to expand and is expandable. If you don't start adding stuff like that now it might never be on quicksnip. This is the same with CMake and a lot more stuff that you are currently blocking. You should stop blocking it because it doesn't fit now but might later.
You can already close this if you want. Just respond with a full answer so I can fully understand.
The full, simple answer is: We don't accept examples.
Yes we accept library snippets but not examples on how to use them.
Sorry for being repetitive with things and stuff but that's literally the whole point of quicksnip is to have examples. What you are saying does not make any sense at all to me (a native British person who speaks English) and so I have decided to close this because it goes absolutely no-where. Please if you get the chance to talk to me again (i'm on the discord) please make more sense instead of going in an endless loop of non-understanding and things meaning the same thing.
Hey @james-beans, thank you for your contribution and pointing out a couple of issues. Will fix it soon. xD
I see there's an already discussion with our maintainer, @Mathys-Gasnier. I'm sorry if the explanation didn't come across clearly. Let me explain:
- Quicksnip focuses on small, reusable function-based snippets that can be copied and pasted into a project with very small changes. More like plug & play.
- While we do accept snippets involving libraries, we don’t include full usage examples or setup guides.
- Your snippet is well-structured, but since it’s more of a configuration guide for a build system, it falls outside Quicksnip's current scope.
Yet, as QuickSnip evolves over time, we might explore expanding its scope to include examples like this. If that happens, I’d be happy to revisit this idea.
I appreciate your interest. If you want to chat more, feel free to reach out on Discord.
No hard feelings, and thanks again for contributing. :)
I never have really understood open-source fully and so I haven't contributed at all before to other projects apart from this before. I was the original person to add 'Hello, World!' snippets to most languages that I knew here. Sorry that I didn't understand and am probably wasting both of your time.
Your snippet is well-structured, but since it’s more of a configuration guide for a build system, it falls outside Quicksnip's current scope.
I understand that and am willing to add longer config / snippets to quicksnip using a different way. See below.
I appreciate your interest. If you want to chat more, feel free to reach out on Discord.
I am willing to talk to you privately on Discord and add a way of adding longer snippets and full config files that would work like mine. My discord is Obviouslyimbeans
you'll probably find me on there messing around.
No hard feelings, and thanks again for contributing. :)
No thank you for having such a great idea for a website I could contribute to for my first time.
@james-beans, No worries. Thanks to you as well. You already have a contributor
tag, so I immediately knew you were a member of our early OG contributors (#17). xD
Description
I have added a nob.h sub-category under C called NOB based on configs that I have made to work with the nob.h build system/library.
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Note: There was an error when building on my Windows 11 system but it was happening even before I made any changes.
I have added a bit in the
package.json
that should of been there instead of thedev
script when starting the project. Just in-case it didn't work on some people's computers. It is calleddev:serve
. And yes I know that just runningdev
on it's own is good enough but addingdev:serve
makes it simpler for contributers if they haven't used Vite before.Spelling is wrong in the pull request format thing (specifically to do with the type of change bit where it says
new snippet
you need to add an s to the end to make it plural or multiple if a user has made multiple changes).Screenshots (Optional)
Click to view screenshots