depend on plotly.js-dist instead of plotly.js #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

archmoj wants to merge 1 commit into master from use-plotly.js-dist

Closed

depend on plotly.js-dist instead of plotly.js #205

archmoj wants to merge 1 commit into master from use-plotly.js-dist

Conversation

archmoj

Copy link

@archmoj archmoj commented Oct 1, 2020

Wondering if this is the right fix in respect to plotly/plotly.js#5182 (comment)?

@dmt0 @nicolaskruchten

@archmoj


 depend on plotly.js-dist instead of plotly.js

d160767

@archmoj archmoj added the bug label

Oct 1, 2020

@archmoj

Copy link

Author

archmoj commented Oct 2, 2020

We could/should possibly hold on this possible "breaking change".
The issue is addressed by plotly/plotly.js#5189 at plotly.js as well as color* dependencies for now.
However considering switching to plotly.js-dist might be an option later on the road.
cc: @alexcjohnson