Redirect plotly.js imports to dist builds #5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

archmoj wants to merge 1 commit into master from redirect-imports-to-dist-builds

Closed

Redirect plotly.js imports to dist builds #5221

archmoj wants to merge 1 commit into master from redirect-imports-to-dist-builds

Conversation

archmoj

Copy link

Contributor

@archmoj archmoj commented Oct 19, 2020

Follow up of #5189 and as suggested by @dy in #5182 (comment).
Changes required to be able to bump & import plotly.js in chart-studio.
Otherwise we have to downgrade color* modules to versions used before #5172.
Potential impacts:

faster and more stable imports/exports in production
may need some adjustments to keep development process smooth

@dmt0
@plotly/plotly_js

@archmoj


 redirect imports to dist builds

cfa979d

@archmoj archmoj added bug status: reviewable regression labels

Oct 19, 2020

@archmoj

Copy link

Contributor Author

archmoj commented Oct 19, 2020

Potential impacts:

may need some adjustments to keep development process smooth

test_dashboard updates & works just fine. So there might be no problem there.

@archmoj

Copy link

Contributor Author

archmoj commented Oct 20, 2020

With this there is now only one test failing on streambed:
https://app.circleci.com/pipelines/github/plotly/streambed/4860/workflows/1a742eea-581a-4e11-9af3-1d569bbf0dae/jobs/59005/parallel-runs/5?filterBy=FAILED

Plus, it might be best to have this change in a minor release.
Therefore in order to fix this in a patch release, I will open a new PR to downgrade color* modules just for now.