-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update map baselines and fix failing font download #7396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've looked at all the image diffs; the only significant change is that (apparently) ocean names are no longer displayed on the basemaps. All of the other differences are minor or invisible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
Wondering if other failing image tests
"various_geo_projections",
"smith_template",
"geo_text_chart_arrays",
"font-wishlist",
"canada_geo_projections"
are related to #7359?
@archmoj I just figured out the source of those failing tests, it's because the Gravitas One font URL changed so the font download failed (see my updated PR comment).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 🙏 Many thanks @emilykl
Switching from master to main broke these.
I suspect a similar problem would occur again.
I feel to avoid file changes (that occur on master/main branch of these repositories) it would be best to use permanent links for all these font files e.g.
https://github.com/expo/google-fonts/tree/cc65b43125023a2ad696eeec6ec10763c35ff588/font-packages/gravitas-one/400Regular instead of https://github.com/expo/google-fonts/blob/main/font-packages/gravitas-one/400Regular/.
Thank you!
Uh oh!
There was an error while loading. Please reload this page.
Image tests on some of the map traces are failing, apparently because Carto made some minor changes to their basemaps. These changes don't seem to be related to anything in our own codebase.
This PR updates the baseline images to match the new basemaps.
This PR also updates the font download URL for Gravitas One in the CI script, which changed due to expo/google-fonts#136. This fixes the other failing image tests. Also updates the CI script such that an error is raised if the font file fails to download, which will make future debugging much easier.