Fix #7387: Specify buffers in regl.clear() to avoid performance warning #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

archmoj merged 1 commit into plotly:master from MzyzzG:fix-7387-clearflags-warning

Jul 7, 2025

Merged

Fix #7387: Specify buffers in regl.clear() to avoid performance warning #7390

archmoj merged 1 commit into plotly:master from MzyzzG:fix-7387-clearflags-warning

Jul 7, 2025

Conversation

MzyzzG

Copy link

Contributor

@MzyzzG MzyzzG commented Mar 16, 2025

This PR fixes issue #7387 by specifying the color and depth buffers in the regl.clear() call in src/traces/scattergl/plot.js. This prevents the "Performance warning: clear() called with no buffers in bitmask" warning.

Changes:

Modified regl.clear({}) to regl.clear({ color: true, depth: true }).

@MzyzzG


 Fix  plotly#7387 : Specify buffers in regl.clear() to avoid performance...

0330e28

... warning

@gvwilson gvwilson added feature community P2 labels

Mar 17, 2025

@archmoj

Copy link

Contributor

archmoj commented Apr 3, 2025

This PR looks good to me.
💯 🙏 Many thanks @zachchan-voltaiq
Thanks to @emilykl's #7396 and in order for the failing tests to pass you could fetch upstream/master and merge it into your PR branch.

Please add a draft log as described here: https://github.com/plotly/plotly.js/tree/master/draftlogs

Also it would be great if you add a jasmine test possibly in test/jasmine/tests/scattergl_test.js to lock the bug you fixed in this PR.

Thank you!