Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Patch #20028 Flaky tests on PHP-8.5 #20031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hakre wants to merge 3 commits into php:PHP-8.5
base: PHP-8.5
Choose a base branch
Loading
from hakre:patch-20028-8.5
Open

Conversation

Copy link
Contributor

@hakre hakre commented Oct 1, 2025
edited
Loading

Flaky tests on PHP 8.5. /cc @bukka

As learned in #18286 a couple of tests were flaky. These are the fixes for them based on PHP-8.5.

Fixes only.

Note

Merge order: #20035 is based on PHP-8.3 with related changes and should be merged first.

@hakre hakre requested a review from bukka as a code owner October 1, 2025 13:53
@hakre hakre changed the base branch from master to PHP-8.5 October 1, 2025 13:54
@hakre hakre mentioned this pull request Oct 1, 2025
hakre added 2 commits October 1, 2025 16:03
As documented in [RunningTests], tests have to be written to be
independent of any php.ini file.
The test expects the environment variable be set both in $_SERVER and in
$_ENV and therefore requires both.
Fix is to set `variables_order` to `ES`.
[RunningTests]: docs/source/miscellaneous/running-tests.rst
As documented in [RunningTests], tests have to be written to be
independent of any php.ini file.
As the tests are based on counting the line terminators, the
mail.add_x_header php.ini setting has to be off.
Fix is to set `mail.add_x_header` to `off`.
[RunningTests]: docs/source/miscellaneous/running-tests.rst
fix-up-of: phpGH-19188 
As documented in [RunningTests], tests have to be written to be
independent of any php.ini file.
Without specifying the timezone, the var_dump() will make use of the
default timezone that may not be the expected "UTC" timezone.
This renders the test-cases flaky and will make them fail if the
`date.timezone` is different from the string "UTC".
Fix is to interpolate the timezone in the test fixture or to set
`date.timezone` to `UTC`.
[RunningTests]: docs/source/miscellaneous/running-tests.rst
@hakre hakre requested a review from derickr as a code owner October 1, 2025 14:58
@hakre hakre changed the title (削除) Patch 20028 8.5 (削除ここまで) (追記) Patch #20028 PHP-8.5 (追記ここまで) Oct 2, 2025
@hakre hakre changed the title (削除) Patch #20028 PHP-8.5 (削除ここまで) (追記) Patch #20028 Flaky tests on PHP-8.5 (追記ここまで) Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@derickr derickr Awaiting requested review from derickr derickr is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /