Commit 4ae31a4

committed

Fix flaky timezone test fixture

As documented in [RunningTests], tests have to be written to be independent of any php.ini file. Without specifying the timezone, the var_dump() will make use of the default timezone that may not be the expected "UTC" timezone. This renders the test-cases flaky and will make them fail if the `date.timezone` is different from the string "UTC". Fix is to interpolate the timezone in the test fixture or to set `date.timezone` to `UTC`. [RunningTests]: docs/source/miscellaneous/running-tests.rst

1 parent 4cb2705 commit 4ae31a4Copy full SHA for 4ae31a4

File tree

1 file changed

-0

lines changed

Zend/tests/inheritance
- deprecation_to_exception_during_inheritance_can_be_caught.phpt

1 file changed

-0

lines changed

`‎Zend/tests/inheritance/deprecation_to_exception_during_inheritance_can_be_caught.phpt‎`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,8 @@ Deprecation promoted to exception during inheritance`
`4`	`4`	`<?php`
`5`	`5`	`if (getenv('SKIP_PRELOAD')) die('skip Error handler not active during preloading');`
`6`	`6`	`?>`
	`7`	`+--INI--`
	`8`	`+date.timezone=UTC`
`7`	`9`	`--FILE--`
`8`	`10`	`<?php`
`9`	`11`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 4ae31a4

File tree

1 file changed

1 file changed

`‎Zend/tests/inheritance/deprecation_to_exception_during_inheritance_can_be_caught.phpt‎`

0 commit comments