Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Message serialization. #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
makasim wants to merge 1 commit into php-enqueue:master
base: master
Choose a base branch
Loading
from Sevavietl:master
Open

Conversation

Copy link
Member

@makasim makasim commented May 15, 2019
edited
Loading

needs queue-interop/queue-interop#28
initial discussion queue-interop/queue-interop#27
further discussion #831

Copy link

stale bot commented Jun 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Contributor

@makasim What are we going to do with the PR to queue-interop? Want me to take over and create a new one?

Copy link
Member Author

makasim commented Sep 25, 2019

Honestly, I don't have a good solution. do not know how to properly address it

Copy link
Contributor

Honestly, I don't have a good solution. do not know how to properly address it

As discussed in the PR in queue-interop, it has been proposed to drop type for body parameter in interface. This would open up ability for implementations to handle message serialization on their own 😄

IMO interface is too tight and limits possible approaches. Some transports could actually benefit from this a lot - for example Redis transport can use IGB (don't recall the proper name on top of my head) serialization that is extension-based.

Copy link
Contributor

and @makasim I'm only asking since @Sevavietl is currently not responding in queue-interop PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /