Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

New message transformation concept #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TiMESPLiNTER wants to merge 3 commits into php-enqueue:master
base: master
Choose a base branch
Loading
from TiMESPLiNTER:feat/pass-message-for-deseriliazation

Conversation

Copy link
Contributor

@TiMESPLiNTER TiMESPLiNTER commented Sep 26, 2019
edited
Loading

This PR aims to deprecate the current Serializer approach and replaces it with a "message transformation concept" which allows to modify the message before after consumption before sending. (For example to de/encode the payload if it's in Avro format.)

This PR should not introduce any BC.

I think the Serializer as of today is really just a workaround for transporting the message headers back when kafka didn't had any support for native headers. As we have it now I think we either should deprecate it and remove it as soon as possible (next major) or replace it with a proper concept (which this PR is a proposal for along with deprecating the Serializer).

wdyt?

Copy link
Contributor

@TiMESPLiNTER Actually you might want to look into #846 and PRs/issues linked in it's description.

Long story short there was a discussion about something similar to what you're proposing, but with the intention of allowing passing arbitrary types as messages to allow custom made serialization on any desired level.

I'll look into your PR further when I've got spare time if you dont mind 😄

Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /