-
Notifications
You must be signed in to change notification settings - Fork 441
CS Fixes #1372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CS Fixes #1372
Conversation
Changing php-cs-fixer config filename to the default so it's detected without having to specify the config flag
Running php-cs-fixer to fix CS drift
when specifying multiple files php-cs-fixer needs to be provider rules or the config file. see PHP-CS-Fixer/PHP-CS-Fixer#4279
2b3f908 to
8e72d15
Compare
@makasim I've fixed the code style checks and that's now green.
But there's an issue with Symfony 6.2/6.3. I've spent some time debugging it but have not gotten anywhere yet. However, it doesn't look like the CS fixes have caused this.
I've checked out 0.10.24 and still get the failures.
@JimTools thank you
@makasim you’re welcome, the static analysis changes should be good to go as well.
I’ll continue looking into CI failures and fix the rest of the warnings in the test output
kravchenko-a
commented
Apr 15, 2025
@makasim Hello Max!
Tell me please, when will be a new releases with new versions of this changes? 🙏
The last published versions were in 2024 and its incompatible with PHP 8.4 due to deprecations of "Implicitly marking parameter as nullable". 😞
What plans do you have for this?
Uh oh!
There was an error while loading. Please reload this page.
closes #1336 #1369