-
Notifications
You must be signed in to change notification settings - Fork 441
Fixing risky tests #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing risky tests #1371
Conversation
Makring tests that have no assertions with the annotation to suppress phpunits warning around risky tests closes 1370
To be honest I don't think a lot of these tests bring value, for the most part, they just test the constructor works can get a new instance.
It seemed like a good idea at the time of writing (6-8 years ago). Now, I agree with you that such tests bring no value. If you want you can remove them.
To be honest I don't think a lot of these tests bring value, for the most part, they just test the constructor works can get a new instance.
I’ll work on updating this to remove tests that have little to no value.
As for the CS and static analysis I’ll raise another PR to fix this.
Removing all tests that creates a new instance but doesn't call any methods nor preform any assertions.
Fixed CS issues in #1372
I don't really want to keep master red, but considering you plan to address all issues eventually as separate MRs I am fine with it.
Making tests that have no assertions with the annotation to suppress phpunits warning around risky tests
closes #1370