-
Notifications
You must be signed in to change notification settings - Fork 536
[FIX]eddy command and multithreading #3721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mauriliogenovese
wants to merge
2
commits into
nipy:master
from
mauriliogenovese:fix-eddy-parallel-and-gpu
Open
[FIX]eddy command and multithreading #3721
mauriliogenovese
wants to merge
2
commits into
nipy:master
from
mauriliogenovese:fix-eddy-parallel-and-gpu
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## master #3721 +/- ## =========================================== + Coverage 2.88% 69.13% +66.24% =========================================== Files 1279 1278 -1 Lines 59413 59271 -142 =========================================== + Hits 1717 40978 +39261 + Misses 57696 18293 -39403 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
the second commit fix this:
EddyInputError: The version compiled for GPU can only use 1 CPU thread (i.e. --nthr=1)
@mauriliogenovese
mauriliogenovese
force-pushed
the
fix-eddy-parallel-and-gpu
branch
from
March 22, 2025 18:03
ce24f3e to
9348f49
Compare
@mauriliogenovese
mauriliogenovese
changed the title
(削除) fix eddy command and multithreading (削除ここまで)
(追記) [FIX]eddy command and multithreading (追記ここまで)
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I will send some PRs to improve/fix fsl cuda-capable tools with the new gpu support.
This one is about eddy:
eddy_openmp is an old command, new fls uses eddy_cpu
eddy_cuda is missing in some version, in those cases if user requests cuda, just use eddy
eddy_cpu does not enable multithread with OMP_NUM_THREADS variable but with --nthr argument