-
-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
Different database backend might require quite different data and struct to create a manager. It causes more harm than good to hard code a struct used to create a db manager.
@gagbo
gagbo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
As you can see activity kind of slowed down here. Yuya has always been a little busy since the .5 release I think, and since then I was able to take over a small part to push .7 to crates.io and finish a few tasks that I needed from the repo. Now I'm also lacking time a bit for happy personal reasons, so I'll try to follow the work being done here since I mostly think this refactoring is a good idea.
The main "big" task I want to add to ktra rather than adding https support or the sparse index RFC implementation (those are great features though!!) is the ability to add a rust-docs feature that handles serving a docs.rs clone just for the crates that ktra is hosting (in its index); the separation between library and binary is definitely a good first step towards that.
Simplifying the code and features is also nice to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this route should be gated by the openid feature: we want to deactivate this route when openid is activated (and all password-based authentication, really) because when I implemented openid support I had to keep inserting tokens in the user database, but they are all bogus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the part that changed the handling of the route
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an extra testing folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably an extra testing folder?
Uh oh!
There was an error while loading. Please reload this page.